Docs: fix issue with client properties name in Kafka connect sink docs - #113236
Conversation
|
Workflow [PR], commit [fd26b6d] Summary: ✅ AI ReviewSummaryThis PR updates the Kafka Connect Sink docs to move client timeout settings from Findings
Final VerdictChanges requested. |
|
|
||
| ```json | ||
| "clickhouseSettings": "socket_timeout=300000,connection_timeout=30000" | ||
| "jdbcConnectionProperties": "?socket_timeout=300000,connection_timeout=30000" |
There was a problem hiding this comment.
jdbcConnectionProperties is documented earlier on this page as a URL query string that starts with ? and joins pairs with &, so this replacement is still not a working example: "?socket_timeout=300000,connection_timeout=30000" keeps the old comma-separated syntax. The page also still has the high-throughput recipe at docs/integrations/connectors/data-ingestion/kafka/kafka-clickhouse-connect-sink.mdx:937 putting socket_timeout into clickhouseSettings, so readers will still see conflicting guidance about where client timeouts belong.
Can we switch this example to "?socket_timeout=300000&connection_timeout=30000" and move the later socket_timeout into jdbcConnectionProperties as well?
1e26bff
Description
Updates Kafka Connect Sink documentation where wrongly mentioned that
clickhouseSettingsshould be used for client config (socket_timeoutandconnection_timeout) while all client settings are passed viajdbcConnectionPropertiesChangelog category (leave one):
Version info
26.8.1.744(included in26.8and later)