rewrite 01171 test#67054
Conversation
|
This is an automated comment for commit f3a9e2b with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
|
Stateless tests flaky check (asan) -- Asan is a heavy build. The test worked 450 seconds and did 39 - 49 iterations. Which is less that threshold 50. I need just correct that threshold. |
|
Stateless Tests (msan) [2/4] --- |
|
Ok. Btw, there is also the |
| kill -TERM $PID_8 | ||
| wait | ||
| wait_for_queries_to_finish 40 | ||
| MAIN_TIME_PART=400 |
There was a problem hiding this comment.
This has made the test 40x slower in release build (used to take 10 seconds, now it takes 400): https://play.clickhouse.com/play?user=play#U2VsZWN0ICogZnJvbSBjaGVja3Mgd2hlcmUgdGVzdF9uYW1lID0gJzAxMTcxX212X3NlbGVjdF9pbnNlcnRfaXNvbGF0aW9uX2xvbmcnIEFORCBjaGVja19uYW1lID0gJ1N0YXRlbGVzcyB0ZXN0cyAocmVsZWFzZSknIGFuZCBwdWxsX3JlcXVlc3RfbnVtYmVyID0gMCBvcmRlciBieSBjaGVja19zdGFydF90aW1lIGRlc2M=
And it's executed in sequential mode. So it's adding 6 minutes to all runs.
There was a problem hiding this comment.
Lets remove no-parallel tag. It should be fine.
I will do this.
01171_mv_select_insert_isolation_long.sh is flaky. Im trying to make it stable.
The main issue that it just works slowly on some heavy builds, like tsan/debug + S3 storage.
Closes: https://github.com/ClickHouse/clickhouse-private/issues/13090
Originally tests did 100 iterations in each thread. It takes a different time depends on build type.
Now it do some amount iterations for fixed time and check that at least
MIN_ITERATIONScount iterations are done.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):