Skip to content

rewrite 01171 test#67054

Merged
alexey-milovidov merged 6 commits intomasterfrom
chesema-01171
Jul 27, 2024
Merged

rewrite 01171 test#67054
alexey-milovidov merged 6 commits intomasterfrom
chesema-01171

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented Jul 24, 2024

01171_mv_select_insert_isolation_long.sh is flaky. Im trying to make it stable.
The main issue that it just works slowly on some heavy builds, like tsan/debug + S3 storage.
Closes: https://github.com/ClickHouse/clickhouse-private/issues/13090

Originally tests did 100 iterations in each thread. It takes a different time depends on build type.
Now it do some amount iterations for fixed time and check that at least MIN_ITERATIONS count iterations are done.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 24, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Jul 24, 2024

This is an automated comment for commit f3a9e2b with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Jul 24, 2024

Stateless tests flaky check (asan) --
It failed very good. I did comprehensive diagnostic.

2024-07-24 18:41:43 Reason: having stderror:  
2024-07-24 18:41:43 45/50 : not enough iterations of select_insert_action has been made from 1721838864 until 1721839294
2024-07-24 18:41:43 46/50 : not enough iterations of select_insert_action has been made from 1721838864 until 1721839294

Asan is a heavy build. The test worked 450 seconds and did 39 - 49 iterations. Which is less that threshold 50. I need just correct that threshold.

@CheSema CheSema marked this pull request as ready for review July 24, 2024 17:34
@CheSema CheSema added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
Comment thread tests/queries/0_stateless/01171_mv_select_insert_isolation_long.sh Outdated
@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Jul 26, 2024

Stateless Tests (msan) [2/4] ---
02481_async_insert_race_long consumed all the memory https://github.com/ClickHouse/clickhouse-private/issues/13101

@alexey-milovidov alexey-milovidov self-assigned this Jul 27, 2024
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jul 27, 2024
@alexey-milovidov
Copy link
Copy Markdown
Member

Ok. Btw, there is also the $SECONDS variable - the time since the script startup.

Merged via the queue into master with commit 46e587b Jul 27, 2024
@alexey-milovidov alexey-milovidov deleted the chesema-01171 branch July 27, 2024 10:36
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 27, 2024
kill -TERM $PID_8
wait
wait_for_queries_to_finish 40
MAIN_TIME_PART=400
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

@CheSema CheSema Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove no-parallel tag. It should be fine.
I will do this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants