Conversation
There was a problem hiding this comment.
400 seconds seem too much, no matter if in parallel or sequential. Why not break out if a certain number of iterations is reached?
There was a problem hiding this comment.
Why not break out if a certain number of iterations is reached?
It was like that recently. It required 100 iterations.
100 iteration on release take ~100 seconds. In debug it takes more that 10 minutes.
So we need to make this iteration limited by time.
I could add MAX_ITERATION that would be what you want.
There was a problem hiding this comment.
I see sub-10 second runs in master with release mode: https://s3.amazonaws.com/clickhouse-test-reports/0/8f60b9776fef6e14ca0e4b4a8b88ab329f17d3f2/stateless_tests__release_.html:
01171_mv_select_insert_isolation_long OK 8.94
There was a problem hiding this comment.
In fact we can see that it has skyrocketed:
It was 12 seconds until 10 of July, then it got 50%-100% slower around 10th of June, and now it's 20x slower
There was a problem hiding this comment.
|
This is an automated comment for commit 851d4d3 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
|
Stateless tests flaky check (asan) |
Algunenano
left a comment
There was a problem hiding this comment.
Kind of complex, but it looks fine. OTOH, the test is flaky so probably not fine.
9994659 to
851d4d3
Compare
Ok, one more run. |
|
Stateless tests flaky check (asan) — ok |
I added
MAX_ITERATIONandMIN_TIME,MAX_TIME.Now the logic is folowed:
MIN_TIMEMAX_ITERATIONandMAX_TIMEMIN_ITERATIONhas been achieved.That allows to run fast on release build and up to
MAX_TIMEon slow builds.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):