Skip to content

run 01171 test in parallel#67470

Merged
CheSema merged 5 commits intomasterfrom
chesema-01171-2
Aug 6, 2024
Merged

run 01171 test in parallel#67470
CheSema merged 5 commits intomasterfrom
chesema-01171-2

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented Jul 30, 2024

I added MAX_ITERATION and MIN_TIME, MAX_TIME.

Now the logic is folowed:

  • run each thread not less that MIN_TIME
  • not much that MAX_ITERATION and MAX_TIME
  • after that it is checked that MIN_ITERATION has been achieved.

That allows to run fast on release build and up to MAX_TIME on slow builds.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@CheSema CheSema mentioned this pull request Jul 30, 2024
19 tasks
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 30, 2024
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

400 seconds seem too much, no matter if in parallel or sequential. Why not break out if a certain number of iterations is reached?

Copy link
Copy Markdown
Member Author

@CheSema CheSema Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not break out if a certain number of iterations is reached?

It was like that recently. It required 100 iterations.
100 iteration on release take ~100 seconds. In debug it takes more that 10 minutes.
So we need to make this iteration limited by time.

I could add MAX_ITERATION that would be what you want.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see sub-10 second runs in master with release mode: https://s3.amazonaws.com/clickhouse-test-reports/0/8f60b9776fef6e14ca0e4b4a8b88ab329f17d3f2/stateless_tests__release_.html:

01171_mv_select_insert_isolation_long	OK	8.94

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 30, 2024

This is an automated comment for commit 851d4d3 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Aug 2, 2024

Stateless tests flaky check (asan)
01171_mv_select_insert_isolation_long -- 1 out of 30 has failed:
19/20 : not enough iterations of select_insert_action has been made from 14 until 414
I could make setting more low, but I think it is ok. No need to run it one more time.

@CheSema CheSema requested a review from Algunenano August 2, 2024 10:24
@Algunenano Algunenano self-assigned this Aug 2, 2024
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of complex, but it looks fine. OTOH, the test is flaky so probably not fine.

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Aug 6, 2024

Kind of complex, but it looks fine. OTOH, the test is flaky so probably not fine.

Ok, one more run.

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Aug 6, 2024

Stateless tests flaky check (asan) — ok

@CheSema CheSema added this pull request to the merge queue Aug 6, 2024
Merged via the queue into master with commit 2ccfc8c Aug 6, 2024
@CheSema CheSema deleted the chesema-01171-2 branch August 6, 2024 20:13
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 6, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants