Try not to re-caclculate indexes in requestReadingInOrder#99084
Merged
Try not to re-caclculate indexes in requestReadingInOrder#99084
Conversation
Contributor
|
Workflow [PR], commit [1dcc299] Summary: ❌
|
Contributor
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 100.00% (11/11) |
CurtizJ
approved these changes
Mar 10, 2026
Member
|
Let's backport this change. So, please write a changelog entry. |
This was referenced Mar 10, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Mar 10, 2026
Cherry pick #99084 to 25.12: Try not to re-caclculate indexes in requestReadingInOrder
This was referenced Mar 10, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Mar 10, 2026
Cherry pick #99084 to 26.1: Try not to re-caclculate indexes in requestReadingInOrder
robot-clickhouse
added a commit
that referenced
this pull request
Mar 10, 2026
This was referenced Mar 10, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Mar 10, 2026
Cherry pick #99084 to 26.2: Try not to re-caclculate indexes in requestReadingInOrder
robot-clickhouse
added a commit
that referenced
this pull request
Mar 10, 2026
clickhouse-gh bot
added a commit
that referenced
this pull request
Mar 10, 2026
Backport #99084 to 26.2: Try not to re-caclculate indexes in requestReadingInOrder
vdimir
added a commit
that referenced
this pull request
Mar 11, 2026
Backport #99084 to 25.12: Try not to re-caclculate indexes in requestReadingInOrder
vdimir
added a commit
that referenced
this pull request
Mar 11, 2026
Backport #99084 to 26.1: Try not to re-caclculate indexes in requestReadingInOrder
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Followup for #89815
Note
Medium Risk
Changes
ReadFromMergeTree::requestReadingInOrderto stop callingselectRangesToRead(), which could affect how previously-computed analysis results are reused and thus impact read-order execution behavior if assumptions are wrong.Overview
Avoids re-running index/range selection when switching a
ReadFromMergeTreestep to read-in-order.Instead of calling
selectRangesToRead()to recompute analysis,requestReadingInOrder()now directly updates the existingAnalysisResult::read_type(when present and not reading from a projection) based on the requested sort direction.Written by Cursor Bugbot for commit 1dcc299. This will update automatically on new commits. Configure here.