Backport #99084 to 26.1: Try not to re-caclculate indexes in requestReadingInOrder#99187
Merged
Backport #99084 to 26.1: Try not to re-caclculate indexes in requestReadingInOrder#99187
Conversation
3bce608 to
e914a90
Compare
Contributor
|
Workflow [BackportPR], commit [e914a90] Summary: ❌
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #99084
Cherry-pick pull-request #99186
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.
The PR source
The PR is created in the CI job
Note
Medium Risk
Touches MergeTree read planning for the read-in-order optimization; while the change is small, incorrect
read_typepropagation could affect ordering/aggregation behavior in some query plans.Overview
Avoids re-running
selectRangesToRead()whenReadFromMergeTree::requestReadingInOrder()enables the in-order optimization. Instead, if an existinganalyzed_result_ptris present (and not reading from a projection), it now just updatesanalyzed_result_ptr->read_typebased on the requested sort direction (InOrdervsInReverseOrder).Written by Cursor Bugbot for commit e914a90. This will update automatically on new commits. Configure here.