This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 8 - Matilda Ako - JS1 - Week 1 - #222
Closed
MatildaAko wants to merge 6 commits into
Closed
Conversation
Author
|
Hey @haack my assignment is ready for review |
haack
reviewed
Jan 18, 2022
haack
left a comment
haack
left a comment
There was a problem hiding this comment.
Well done 🙌
It looks like prettier (I assume) is replacing the 2 spaces indentation with 4. People have different opinions on which is better but in general you should copy what indentation is already used by the codebase. Otherwise you end up with more changes (you can see these if you look at the diff in this pull request).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? All of it
What did you find hard? Nothing
What do you still not understand? Nothing
Any other notes?
View rendered exercises/L-functions-nested/README.md