Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exercises/B-hello-world/exercise.js
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
console.log("Hello world");
var greeting = "Hello world";
console.log(greeting, greeting, greeting);
4 changes: 2 additions & 2 deletions exercises/C-variables/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Start by creating a variable `greeting`

console.log(greeting);
var greeting = " hello world";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space before the word 'hello' is unnecessary here. I understand that you created it in order to print out 'greeting 'three times in the console including spaces in between. Instead, to fulfil requirements of the task, it would be better to log console three times with 'hello world'.

console.log(greeting, greeting, greeting);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

2 changes: 1 addition & 1 deletion exercises/D-strings/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Start by creating a variable `message`

var message = "This is a string string";
console.log(message);
5 changes: 3 additions & 2 deletions exercises/E-strings-concatenation/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Start by creating a variable `message`

console.log(message);
var greeting = "Hello ";
var name1 = "my name is Maryam.";
console.log(greeting + name1);
5 changes: 3 additions & 2 deletions exercises/F-strings-methods/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Start by creating a variable `message`

console.log(message);
text = " Hello , my name is Bita . ";
let namel = text.length;
console.log(namel);
5 changes: 2 additions & 3 deletions exercises/F-strings-methods/exercise2.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
const name = " Daniel ";

console.log(message);
const myname = " Daniel ";
console.log(myname.trim());

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The console will indeed display 'Daniel' with no white spaces around but it will only be shown in the console not in your program. Instead you could use trim() method on the variable within your code and then console.log would show already trimmed message in the output.

8 changes: 7 additions & 1 deletion exercises/G-numbers/exercise.js
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
// Start by creating a variables `numberOfStudents` and `numberOfMentors`
let numberOfStudents = 15;
let numberOfMentors = 8;
let subtotal = numberOfStudents + numberOfMentors;

@hachi-ops hachi-ops Dec 17, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to call it 'total' instead but it is not a big deal anyway:) the name 'subtotal' suggests here that you intend to add something to it.

let mentorpercent = (numberOfMentors * 100) / subtotal;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The math is good here.

let studentpercent = (numberOfStudents * 100) / subtotal;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

console.log("percentage of students is :", studentpercent);
console.log("percentage of mentors is :", mentorpercent);
5 changes: 5 additions & 0 deletions exercises/I-floats/exercise.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
var numberOfStudents = 15;
var numberOfMentors = 8;
let subtotal = numberOfStudents + numberOfMentors;
let mentorpercent = (numberOfMentors * 100) / subtotal;
let studentpercent = (numberOfStudents * 100) / subtotal;
console.log("percentage of students is :", Math.round(studentpercent));
console.log("percentage of mentors is :", Math.round(mentorpercent));

@hachi-ops hachi-ops Dec 17, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again , I think to fulfil the requirements of the task you should have used Math.round() method within your program (on variables) instead of in the console.log

3 changes: 1 addition & 2 deletions exercises/J-functions/exercise.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
function halve(number) {
// complete the function here
return number / 2;
}

var result = halve(12);

console.log(result);
2 changes: 1 addition & 1 deletion exercises/J-functions/exercise2.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
function triple(number) {
// complete function here
return number * 3;
}

var result = triple(12);
Expand Down
4 changes: 2 additions & 2 deletions exercises/K-functions-parameters/exercise.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Complete the function so that it takes input parameters
function multiply() {
// Calculate the result of the function and return it
function multiply(a, b) {
return a * b;
}

// Assign the result of calling the function the variable `result`
Expand Down
4 changes: 3 additions & 1 deletion exercises/K-functions-parameters/exercise2.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
// Declare your function first
function divide(a, b) {
return a / b;
}

var result = divide(3, 4);

Expand Down
4 changes: 3 additions & 1 deletion exercises/K-functions-parameters/exercise3.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
// Write your function here
function createGreeting(a) {
return "Hello , my name is " + a;
}

var greeting = createGreeting("Daniel");

Expand Down
8 changes: 5 additions & 3 deletions exercises/K-functions-parameters/exercise4.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Declare your function first

function sum1(a, b) {
// Declare your function first
return a + b;
}
// Call the function and assign to a variable `sum`

var sum = sum1(13, 124);
console.log(sum);
6 changes: 4 additions & 2 deletions exercises/K-functions-parameters/exercise5.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Declare your function here

function createLongGreeting(a, b) {
// Declare your function here
return "Hello , my name is " + a + "and I'm " + b + "years old.";
}
const greeting = createLongGreeting("Daniel", 30);

console.log(greeting);
6 changes: 6 additions & 0 deletions exercises/L-functions-nested/exercise.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ var mentor2 = "Irina";
var mentor3 = "Mimi";
var mentor4 = "Rob";
var mentor5 = "Yohannes";

function makeuppercase(text) {
let mentorname = text.UpperCase();
return mentorname;
}
console.log(makeuppercase(mentor1));

@hachi-ops hachi-ops Dec 17, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is very good. You have correctly transformed your variable to uppercase within your code and then displayed the function containing it in the console to check the output of your program.

16 changes: 8 additions & 8 deletions mandatory/1-syntax-errors.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
// There are syntax errors in this code - can you fix it to pass the tests?

function addNumbers(a b c) {
function addNumbers(a, b, c) {
return a + b + c;
}

function introduceMe(name, age)
return "Hello, my name is " + name "and I am " age + "years old";

function introduceMe(name, age) {
return "Hello, my name is " + name + " and I am " + age + " years old";
}
function getTotal(a, b) {
total = a ++ b;
total = a + b;

return "The total is total";
return "The total is " + total;
}

/*
===================================================
console.log(addNumbers(2, 3, 4));
/* ===================================================
======= TESTS - DO NOT MODIFY BELOW THIS LINE =====

There are some Tests in this file that will help you work out if your code is working.
Expand Down
7 changes: 3 additions & 4 deletions mandatory/2-logic-error.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// The syntax for this function is valid but it has an error, find it and fix it.

function trimWord(word) {
return wordtrim();
return word.trim();
}

function getStringLength(word) {
return "word".length();
return word.length;
}

function multiply(a, b, c) {
a * b * c;
return;
return a * b * c;
}

/*
Expand Down
2 changes: 1 addition & 1 deletion mandatory/3-function-output.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Add comments to explain what this function does. You're meant to use Google!
function getRandomNumber() {
function getRandomNumber(numbers) {
return Math.random() * 10;
}

Expand Down
15 changes: 12 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,30 @@
"url": "https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1/issues"
},
"jest": {
"setupFilesAfterEnv": ["jest-extended"],
"setupFilesAfterEnv": [
"jest-extended"
],
"projects": [
{
"displayName": "mandatory",
"testMatch": ["<rootDir>/mandatory/*.js"]
"testMatch": [
"<rootDir>/mandatory/*.js"
]
},
{
"displayName": "extra",
"testMatch": ["<rootDir>/extra/*.js"]
"testMatch": [
"<rootDir>/extra/*.js"
]
}
]
},
"homepage": "https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1#readme",
"devDependencies": {
"jest": "^26.6.3",
"jest-extended": "^0.11.5"
},
"dependencies": {
"extending": "^0.2.0"
}
}