-
-
Notifications
You must be signed in to change notification settings - Fork 475
London-8-Maryam-Mohsenpour-JavaScript-core-1-coursework-week1 #257
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| console.log("Hello world"); | ||
| var greeting = "Hello world"; | ||
| console.log(greeting, greeting, greeting); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| // Start by creating a variable `greeting` | ||
|
|
||
| console.log(greeting); | ||
| var greeting = " hello world"; | ||
| console.log(greeting, greeting, greeting); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| // Start by creating a variable `message` | ||
|
|
||
| var message = "This is a string string"; | ||
| console.log(message); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| // Start by creating a variable `message` | ||
|
|
||
| console.log(message); | ||
| var greeting = "Hello "; | ||
| var name1 = "my name is Maryam."; | ||
| console.log(greeting + name1); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| // Start by creating a variable `message` | ||
|
|
||
| console.log(message); | ||
| text = " Hello , my name is Bita . "; | ||
| let namel = text.length; | ||
| console.log(namel); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,2 @@ | ||
| const name = " Daniel "; | ||
|
|
||
| console.log(message); | ||
| const myname = " Daniel "; | ||
| console.log(myname.trim()); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The console will indeed display 'Daniel' with no white spaces around but it will only be shown in the console not in your program. Instead you could use trim() method on the variable within your code and then console.log would show already trimmed message in the output. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| // Start by creating a variables `numberOfStudents` and `numberOfMentors` | ||
| let numberOfStudents = 15; | ||
| let numberOfMentors = 8; | ||
| let subtotal = numberOfStudents + numberOfMentors; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps it would be better to call it 'total' instead but it is not a big deal anyway:) the name 'subtotal' suggests here that you intend to add something to it. |
||
| let mentorpercent = (numberOfMentors * 100) / subtotal; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The math is good here. |
||
| let studentpercent = (numberOfStudents * 100) / subtotal; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above |
||
| console.log("percentage of students is :", studentpercent); | ||
| console.log("percentage of mentors is :", mentorpercent); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,7 @@ | ||
| var numberOfStudents = 15; | ||
| var numberOfMentors = 8; | ||
| let subtotal = numberOfStudents + numberOfMentors; | ||
| let mentorpercent = (numberOfMentors * 100) / subtotal; | ||
| let studentpercent = (numberOfStudents * 100) / subtotal; | ||
| console.log("percentage of students is :", Math.round(studentpercent)); | ||
| console.log("percentage of mentors is :", Math.round(mentorpercent)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again , I think to fulfil the requirements of the task you should have used Math.round() method within your program (on variables) instead of in the console.log |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| function halve(number) { | ||
| // complete the function here | ||
| return number / 2; | ||
| } | ||
|
|
||
| var result = halve(12); | ||
|
|
||
| console.log(result); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| function triple(number) { | ||
| // complete function here | ||
| return number * 3; | ||
| } | ||
|
|
||
| var result = triple(12); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| // Declare your function first | ||
| function divide(a, b) { | ||
| return a / b; | ||
| } | ||
|
|
||
| var result = divide(3, 4); | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| // Declare your function first | ||
|
|
||
| function sum1(a, b) { | ||
| // Declare your function first | ||
| return a + b; | ||
| } | ||
| // Call the function and assign to a variable `sum` | ||
|
|
||
| var sum = sum1(13, 124); | ||
| console.log(sum); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| // Declare your function here | ||
|
|
||
| function createLongGreeting(a, b) { | ||
| // Declare your function here | ||
| return "Hello , my name is " + a + "and I'm " + b + "years old."; | ||
| } | ||
| const greeting = createLongGreeting("Daniel", 30); | ||
|
|
||
| console.log(greeting); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,9 @@ var mentor2 = "Irina"; | |
| var mentor3 = "Mimi"; | ||
| var mentor4 = "Rob"; | ||
| var mentor5 = "Yohannes"; | ||
|
|
||
| function makeuppercase(text) { | ||
| let mentorname = text.UpperCase(); | ||
| return mentorname; | ||
| } | ||
| console.log(makeuppercase(mentor1)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is very good. You have correctly transformed your variable to uppercase within your code and then displayed the function containing it in the console to check the output of your program. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A space before the word 'hello' is unnecessary here. I understand that you created it in order to print out 'greeting 'three times in the console including spaces in between. Instead, to fulfil requirements of the task, it would be better to log console three times with 'hello world'.