This repository was archived by the owner on Jan 14, 2024. It is now read-only.
solve the errors | London10 | Seyyednavid Hejazijouybari | Javascript | week1 - #472
Open
seyyednavid wants to merge 13 commits into
Open
solve the errors | London10 | Seyyednavid Hejazijouybari | Javascript | week1 #472seyyednavid wants to merge 13 commits into
seyyednavid wants to merge 13 commits into
Conversation
seyyednavid
changed the title
SeyoungJoo
reviewed
Feb 20, 2023
|
|
||
| function convertToUSD() {} | ||
| function convertToUSD(PoundAmount) { | ||
| let usdAmount = (PoundAmount * 1.4) |
There was a problem hiding this comment.
Is there a reason you're using let instead of const?
if you're not going to reassign the value again, you should always declare variables with const as a general rule
Author
There was a problem hiding this comment.
Thank you Seyoung for your guidance. I'll changed it.
SeyoungJoo
reviewed
Feb 20, 2023
| */ | ||
|
|
||
| function convertToBRL() {} | ||
| function convertToBRL(PoundAmount) { |
There was a problem hiding this comment.
recommend to use lower case for parameter
SeyoungJoo
reviewed
Feb 20, 2023
| ...positive, | ||
| ...negative, | ||
| ...veryNegative, | ||
| ]; |
SeyoungJoo
reviewed
Feb 20, 2023
| /* BETTER PRACTICE */ | ||
|
|
||
| let goodCode = | ||
| let goodCode = "£".concat((startingValue * 12)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?