This repository was archived by the owner on Jan 14, 2024. It is now read-only.
mandatory part update - #507
Open
fowobi wants to merge 10 commits into
Open
Conversation
finish the mandatory part
mandatory answer on JavaScript core1
update
answer to 3 function output
gregdyke
reviewed
Feb 22, 2023
gregdyke
left a comment
Contributor
There was a problem hiding this comment.
Hi Tosin
This is good work, well done!
Next time you open a pull request could you give it the title we request? Something like
Glasgow Class 6 - Tosin Odunuga - JS1 Week 1
| // Add comments to explain what this function does. You're meant to use Google! | ||
| function combine2Words(word1, word2) { | ||
| return word1.concat(word2); | ||
|
|
Contributor
There was a problem hiding this comment.
Can you add a comment to explain what this function does (instead of changing the function?)
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(price) { | ||
| let pricewithtax = calculateSalesTax(price); | ||
| return '£' + pricewithtax.toFixed(2); |
Author
|
Ok,I will correct it.
Thank you
…On Wed, 22 Feb 2023, 13:17 gregdyke, ***@***.***> wrote:
***@***.**** commented on this pull request.
Hi Tosin
This is good work, well done!
Next time you open a pull request could you give it the title we request?
Something like
Glasgow Class 6 - Tosin Odunuga - JS1 Week 1
------------------------------
In mandatory/3-function-output.js
<#507 (comment)>
:
> function getRandomNumber() {
return Math.random() * 10;
}
// Add comments to explain what this function does. You're meant to use Google!
function combine2Words(word1, word2) {
- return word1.concat(word2);
+
Can you add a comment to explain what this function does (instead of
changing the function?)
------------------------------
In mandatory/4-tax.js
<#507 (comment)>
:
> @@ -17,7 +19,10 @@ function calculateSalesTax() {}
Remember that the prices must include the sales tax (hint: you already wrote a function for this!)
*/
-function addTaxAndFormatCurrency() {}
+function addTaxAndFormatCurrency(price) {
+ let pricewithtax = calculateSalesTax(price);
+ return '£' + pricewithtax.toFixed(2);
nicely done!
—
Reply to this email directly, view it on GitHub
<#507 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2GGUINFCH6YDXVLZC4HPFLWYYGV5ANCNFSM6AAAAAAVCIZLGE>
.
You are receiving this because you authored the thread.Message ID:
<CodeYourFuture/JavaScript-Core-1-Coursework-Week1/pull/507/review/1309207137
@github.com>
|
Adding comment
added comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finish the mandatory part
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryGlasgow Class 6 - Tosin Odunuga - JS1 - Week 1
Your Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?