Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

mandatory part update - #507

Open
fowobi wants to merge 10 commits into
CodeYourFuture:masterfrom
fowobi:master
Open

mandatory part update#507
fowobi wants to merge 10 commits into
CodeYourFuture:masterfrom
fowobi:master

Conversation

@fowobi

@fowobi fowobi commented Feb 20, 2023

Copy link
Copy Markdown

finish the mandatory part

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Glasgow Class 6 - Tosin Odunuga - JS1 - Week 1

Your Details

  • Your Name:Tosin_Odunuga
  • Your City: Glasgow class 6
  • Your Slack Name: Tosin

Homework Details

  • Module:JavaScript
  • Week: 1

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

finish the mandatory part
mandatory answer on JavaScript core1
answer to 3 function output

@gregdyke gregdyke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tosin

This is good work, well done!

Next time you open a pull request could you give it the title we request? Something like

Glasgow Class 6 - Tosin Odunuga - JS1 Week 1

// Add comments to explain what this function does. You're meant to use Google!
function combine2Words(word1, word2) {
return word1.concat(word2);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to explain what this function does (instead of changing the function?)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I will do that

Comment thread mandatory/4-tax.js
function addTaxAndFormatCurrency() {}
function addTaxAndFormatCurrency(price) {
let pricewithtax = calculateSalesTax(price);
return '£' + pricewithtax.toFixed(2);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done!

@fowobi

fowobi commented Feb 22, 2023 via email

Copy link
Copy Markdown
Author

@fowobi fowobi added the review requested I would like a mentor to review my PR label Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

review requested I would like a mentor to review my PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants