Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London Class 9 - Leila Farsani -JavaScript-Core-2-Coursework-Week1 - #158

Open
leilafarsani wants to merge 3 commits into
CodeYourFuture:mainfrom
leilafarsani:main
Open

London Class 9 - Leila Farsani -JavaScript-Core-2-Coursework-Week1#158
leilafarsani wants to merge 3 commits into
CodeYourFuture:mainfrom
leilafarsani:main

Conversation

@leilafarsani

@leilafarsani leilafarsani commented Dec 18, 2022

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Leila Farsani
  • Your City: London
  • Your Slack Name: Leila Farsani

Homework Details

  • Module: JavaScript Core 2
  • Week: 1

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

@jonnywyatt jonnywyatt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, you've aced this!

Comment thread 2-mandatory/1-recipes.js
]
};

console.log(veganDessert_1.title);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine. To improve it even further, how could you store the recipes so you can loop through them and write the console.log code only once?

return currencyCodes;

-----------OR------------ */
return Object.fromEntries(countryCurrencyCodes);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

// write code here
let allContent = pantry.fridgeContents.concat(pantry.cupboardContents);
let missingIngredients = recipe.ingredients
.filter(ingredient => allContent.indexOf(ingredient) === -1);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, or alternatively !allContent.includes(ingredient)

Comment thread 3-extra/1-count-words.js
if (string.trim().length === 0) {
return wordCount;
}
string.split(" ").map((word) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant 👏

@jonnywyatt jonnywyatt added the reviewed A mentor has reviewed this code label Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

reviewed A mentor has reviewed this code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants