This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London9 - Lovelace - Bahare Bahreinian - JavaScript-Core 2 - Week 1 - #160
Open
Bahare09 wants to merge 4 commits into
Open
London9 - Lovelace - Bahare Bahreinian - JavaScript-Core 2 - Week 1 #160Bahare09 wants to merge 4 commits into
Bahare09 wants to merge 4 commits into
Conversation
ellietms
reviewed
Dec 30, 2022
| // write code here | ||
|
|
||
| basketballTeam.topPlayers.sort().forEach((item) => console.log(item)); | ||
|
|
| if ((student["attendance"] = 90 && student["examScore"] > 60)) { | ||
| student["hasPassed"] = true; | ||
| } else student["hasPassed"] = false; | ||
|
|
Member
There was a problem hiding this comment.
well done, also you can use ternary operator
| console.log("Serves: " + favoriteRecipe[i].servings); | ||
| console.log("Ingredients:"); | ||
| favoriteRecipe[i].ingredients.forEach((item) => console.log(item)); | ||
| } |
Member
There was a problem hiding this comment.
nice :) , you can use favorite recipe.length in your for loop, what if someone adds a recipe to your array?
| let missItems = recipe.ingredients.filter( | ||
| (item) => | ||
| pantry.fridgeContents.indexOf(item) === -1 && | ||
| pantry.cupboardContents.indexOf(item) === -1 |
Member
There was a problem hiding this comment.
you can merge these 2 arrays together and just check that array (array which includes all items in pantry.fridgeCiontent and pantry.cupboardContent)
|
|
||
| function createLookup(countryCurrencyCodes) { | ||
| // write code here | ||
| return Object.assign(...COUNTRY_CURRENCY_CODES.map((d) => ({ [d[0]]: d[1] })) |
Member
There was a problem hiding this comment.
instead of using d (as a variable name) , always use a variable name with meaningful name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?