This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London 9 - Andriana Saffo - JavaScript 2 - Week 1 - #171
Open
AndrianaOS wants to merge 12 commits into
Open
Conversation
ellietms
reviewed
Dec 30, 2022
| sortedNames.forEach((name) => { | ||
| console.log(name); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
great job, you can also use forEach straight away instead of using a variable and then use forEach
basketballTeam.topPlayers.sort().forEach(name => console.log(name))
| orderBurger: function (balance) { | ||
| if (balance >= MENU.burger) { | ||
| let newBalance = MENU.burger - balance; | ||
| return newBalance; |
Member
There was a problem hiding this comment.
good job, you do not need a new variable here, you can return the value straight away
you can use ternary operator too if you would like
| } | ||
| }, | ||
| }; | ||
|
|
| newShoppingList.items = []; | ||
|
|
||
| const pantryList = Object.values(pantry).flat(); | ||
|
|
Member
There was a problem hiding this comment.
good job, you can also use concat to merge two arrays together :)
| console.log(`${key}: ${eachRecipe[key]}`); | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
good job, where are the allRecipes? :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
Accessing items in an object using dot notation
What did you find hard?
Finding missing items from 2 separate objects
What do you still not understand?
Any other notes?
Exercises completed. Only 1 mandatory exercise left to complete