Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 2 |debug address/author/recipe, implement contains/lookup/tall - #1410
Open
KhotKeys wants to merge 1 commit into
Open
Conversation
…y/querystring, fix invert, refactor mode, implement count-words/till
KhotKeys
added
📅 Sprint 2
cjyuan
reviewed
Aug 10, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just one question.
| function contains() {} | ||
| function contains(obj, prop) { | ||
| if (typeof obj !== "object" || obj === null || Array.isArray(obj)) return false; | ||
| return Object.prototype.hasOwnProperty.call(obj, prop); |
Contributor
There was a problem hiding this comment.
Note: Could also use Object.hasOwn() -- shorter syntax.
Comment on lines
+3
to
+6
| return arr.reduce((acc, item) => { | ||
| acc[item] = (acc[item] || 0) + 1; | ||
| return acc; | ||
| }, {}); |
Contributor
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion:
- Look up an approach to create an empty object with no inherited properties, or
- use
Object.hasOwn()
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist