NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | Quote Generator #803

TzeMingHo · 2025-10-26T17:09:42Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Implemented a button to change the quote and author generated randomly from the array.
Added a toggle button for auto-displaying a new quote and author in a few seconds.
Some styling in css

github-actions · 2025-10-26T17:10:00Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T17:10:18Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T17:10:19Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T00:05:11Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T00:05:11Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T00:05:16Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

sambabib · 2025-11-01T00:18:32Z

Sprint-3/quote-generator/quotes.js

+  updateQuoteAndAuthor();
+  document
+    .getElementById("new-quote")
+    .addEventListener("click", updateQuoteAndAuthor);


You have implemented the first part of this task quite well. However, you have yet to attempt the "auto-generate" task. Why is that?

I was concerned that I couldn't figure out why the second test keeps failing. So, I made this pull request to seek for guidelines. However, if it is ok to move on, I would love to try implementing new features.

Hi sambabib,
I have added an auto-update feature for the quote generator.

github-actions · 2025-11-01T00:19:03Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T00:19:04Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:01Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:01Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:03Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:30Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

mjpeet · 2025-11-05T14:50:45Z

@TzeMingHo for some reason the github action thinks some of the template fields have not been filled properly

the only thing i can see is the title maybe?

if you look at this PR #788

--> the title says Quote Generator (at the end (without dash), can you try and rename your PR? (if you get any more github action issues, try to see what the difference is against the above mentioned PR)

cifarquhar · 2025-11-06T14:57:13Z

@sambabib @mjpeet When you next look at this could you see if the tests pass? I had a look at this with @TzeMingHo in a paired session this morning and the can change quote to another random quote test gives an assertion error - it looks like the text isn't updating. I saw the app working though, it's updating the DOM correctly. Doesn't look like it's been flagged in any other PRs for this exercise. Have I missed a bug, or do you think the test is checking the value before the function has finished updating it?

sambabib · 2025-11-10T00:55:13Z

@sambabib @mjpeet When you next look at this could you see if the tests pass? I had a look at this with @TzeMingHo in a paired session this morning and the can change quote to another random quote test gives an assertion error - it looks like the text isn't updating. I saw the app working though, it's updating the DOM correctly. Doesn't look like it's been flagged in any other PRs for this exercise. Have I missed a bug, or do you think the test is checking the value before the function has finished updating it?

is there a way for me to see these written tests?

TzeMingHo · 2025-11-10T12:22:40Z

@sambabib @mjpeet When you next look at this could you see if the tests pass? I had a look at this with @TzeMingHo in a paired session this morning and the can change quote to another random quote test gives an assertion error - it looks like the text isn't updating. I saw the app working though, it's updating the DOM correctly. Doesn't look like it's been flagged in any other PRs for this exercise. Have I missed a bug, or do you think the test is checking the value before the function has finished updating it?

is there a way for me to see these written tests?

The test file is in the same folder named Quote-Generator in this repository. I was not supposed to make any changes to the test file, so it is not in the file changed section.

sambabib · 2025-11-11T21:04:26Z

@sambabib @mjpeet When you next look at this could you see if the tests pass? I had a look at this with @TzeMingHo in a paired session this morning and the can change quote to another random quote test gives an assertion error - it looks like the text isn't updating. I saw the app working though, it's updating the DOM correctly. Doesn't look like it's been flagged in any other PRs for this exercise. Have I missed a bug, or do you think the test is checking the value before the function has finished updating it?

is there a way for me to see these written tests?

The test file is in the same folder named Quote-Generator in this repository. I was not supposed to make any changes to the test file, so it is not in the file changed section.

what seems to be the issue then?

TzeMingHo · 2025-11-12T10:04:36Z

@sambabib @mjpeet When you next look at this could you see if the tests pass? I had a look at this with @TzeMingHo in a paired session this morning and the can change quote to another random quote test gives an assertion error - it looks like the text isn't updating. I saw the app working though, it's updating the DOM correctly. Doesn't look like it's been flagged in any other PRs for this exercise. Have I missed a bug, or do you think the test is checking the value before the function has finished updating it?

is there a way for me to see these written tests?

The test file is in the same folder named Quote-Generator in this repository. I was not supposed to make any changes to the test file, so it is not in the file changed section.

what seems to be the issue then?

When I tried to run the tests, the second one kept failing, even though I could actually randomly generate a new quote when I clicked the button. I was asking for a hint why this may happened.

Colin had a look of the code, it may be induced by a race condition and the app didn't have enough time to update the quote to pass the test.

TzeMingHo · 2025-11-14T17:28:11Z

@sambabib @mjpeet @cifarquhar

Hello. The issue of not passing the second test has been resolved. After Jennet had very kindly looked for the different versions of userEvent used in the tests, she found that the tests were written in version 13 instead of 14, which some students had.

When I reinstall "@testing-library/user-event": "^13.5.0", both tests pass.

sambabib · 2025-11-15T08:14:37Z

@sambabib @mjpeet @cifarquhar

Hello. The issue of not passing the second test has been resolved. After Jennet had very kindly looked for the different versions of userEvent used in the tests, she found that the tests were written in version 13 instead of 14, which some students had.

When I reinstall "@testing-library/user-event": "^13.5.0", both tests pass.

will you be attempting the "stretch" portion of this assignment then?

TzeMingHo · 2025-11-15T08:38:17Z

@sambabib @mjpeet @cifarquhar

Hello. The issue of not passing the second test has been resolved. After Jennet had very kindly looked for the different versions of userEvent used in the tests, she found that the tests were written in version 13 instead of 14, which some students had.

When I reinstall "@testing-library/user-event": "^13.5.0", both tests pass.

will you be attempting the "stretch" portion of this assignment then?

If you are talking about the auto generator of quotes, I have already attempted to implement it.

bp7968h

Nice work, some minor code improvements, otherwise looks good to me

bp7968h · 2025-12-03T00:27:59Z

Sprint-3/quote-generator/index.html

+      <label class="switch">
+        <input id="toggle-btn" type="checkbox" />
+        <span class="slider round"></span>
+      </label>


Would the screen reader be able to understand what this button is for from the context?

Thank you, Bhuwan. I should have added an aria-label for the input.

bp7968h · 2025-12-03T00:33:58Z

Sprint-3/quote-generator/quotes.js

+      intervalId = setInterval(() => {
+        updateQuoteAndAuthor();
+      }, 3000);


In the readme for this task, the submission it mentions that auto quote should have 60 seconds interval when changing. Does this auto change in 60 secs, how would you fix that. Also this 3000 in your code are known as magic numbers, is there better way to handle magic numbers

Yes. I have added two variables for a preferred second and MS, which could improve readability.

bp7968h

Looks good to me!

making the quote app works but failing the second test

21aa7aa

TzeMingHo added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

TzeMingHo added 2 commits October 26, 2025 17:11

updated index.html

081238f

added css styling

ffe6668

sambabib reviewed Nov 1, 2025

View reviewed changes

sambabib added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 1, 2025

TzeMingHo mentioned this pull request Nov 2, 2025

NW | 25-ITP-Sep | Data groups | TzeMing Ho TzeMingHo/My-Coursework-Planner#40

Open

TzeMingHo added 2 commits November 2, 2025 18:06

adding a toggle button

75d1246

implemented auto generator

4e2d6df

TzeMingHo added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 3, 2025

TzeMingHo requested a review from sambabib November 5, 2025 15:35

tests are passed with testing-library/userEvent@13

e28e98d

TzeMingHo added 2 commits November 18, 2025 11:42

changed drive's name

11a4d4b

updated display setting

a9ba9ed

TzeMingHo force-pushed the quote-generator branch from 394c885 to a9ba9ed Compare November 21, 2025 17:15

bp7968h suggested changes Dec 3, 2025

View reviewed changes

bp7968h added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 3, 2025

added aria-label for auto button, and variables for interval seconds

0e1bfe2

TzeMingHo requested a review from bp7968h December 3, 2025 13:35

bp7968h approved these changes Dec 3, 2025

View reviewed changes

bp7968h added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 3, 2025

Uh oh!

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | Quote Generator #803

Are you sure you want to change the base?

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | Quote Generator #803

Uh oh!

Conversation

TzeMingHo commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

sambabib Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

TzeMingHo Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

TzeMingHo Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

mjpeet commented Nov 5, 2025

Uh oh!

cifarquhar commented Nov 6, 2025

Uh oh!

sambabib commented Nov 10, 2025

Uh oh!

TzeMingHo commented Nov 10, 2025

Uh oh!

sambabib commented Nov 11, 2025

Uh oh!

TzeMingHo commented Nov 12, 2025

Uh oh!

TzeMingHo commented Nov 14, 2025

Uh oh!

sambabib commented Nov 15, 2025

Uh oh!

TzeMingHo commented Nov 15, 2025

Uh oh!

bp7968h left a comment

Choose a reason for hiding this comment

Uh oh!

bp7968h Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

TzeMingHo Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

bp7968h Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

TzeMingHo Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

bp7968h left a comment

Choose a reason for hiding this comment

Uh oh!

TzeMingHo commented Oct 26, 2025 •

edited

Loading