London | 25-ITP-September | Ammad Ur Rehman | Sprint 3 | [TECH ED] Build quote generator app

[anosidium]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Done everything including the stretch.

Questions

Nope.

[bp7968h]

Nice work completing both main task and the stretch task.

I've left some questions inline about semantic HTML and variable naming, have a look into those. One thing I noticed: The stretch goal requirements mention:

"the generator should display 'auto-play:ON' somewhere on the page"

Currently, this text doesn't appear when the checkbox is checked. How would you add this feature. In relation to this feature, you immediately display new quote when checkbox is checked, this is good approach as the user will have instant feedback that the checkbox have side effect. But when you add the auto-play:ON display, do you need that? Is the side effect conveyed to the user?

[anosidium]

Thanks for the review, I have made the changes based on your suggestions.

[bp7968h]

The task is well done, and meets the requirements.