London | 26-ITP-May | Jorvan White | Sprint 1 | Form-Controls #1265
Open
JorvanW wants to merge 1 commit into
Open
London | 26-ITP-May | Jorvan White | Sprint 1 | Form-Controls #1265JorvanW wants to merge 1 commit into
JorvanW wants to merge 1 commit into
Conversation
Created via VSC
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JorvanW
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
JorvanW
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 18, 2026
There was a problem hiding this comment.
Why did you create a new file and not use the index.html?
| font-size: 20px; | ||
| width: 100px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
How can you ensure clear separation of styling and html elements?
Comment on lines
+30
to
+54
| <input> | ||
| </div> | ||
| <div> | ||
| <label>Email</label> | ||
| <input> | ||
| </div> | ||
| <div> | ||
| <label>Size | ||
| <select> | ||
| <option value="xsmall">XS</option> | ||
| <option value="small">S</option> | ||
| <option value="medium">M</option> | ||
| <option value="large">L</option> | ||
| <option value="xlarge">XL</option> | ||
| <option value="xxlarge">XXL</option> | ||
| </select> | ||
| </label> | ||
| </div> | ||
| <div> | ||
| <label>Colour | ||
| <select> | ||
| <option value="yellow">Yellow</option> | ||
| <option value="black">Black</option> | ||
| <option value="pink">Pink</option> | ||
| </select> |
There was a problem hiding this comment.
What are the requirements of the form inputs?
Luro91
added
Reviewed
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created via VSC
Learners, PR Template
Self checklist
Changelist
Ticked off all checklist