Skip to content

London | 26-ITP-MAY | Risikat Popoola| Sprint 2 | Wireframe#1378

Open
risikatpopoola wants to merge 4 commits into
CodeYourFuture:mainfrom
risikatpopoola:feature/wireframe
Open

London | 26-ITP-MAY | Risikat Popoola| Sprint 2 | Wireframe#1378
risikatpopoola wants to merge 4 commits into
CodeYourFuture:mainfrom
risikatpopoola:feature/wireframe

Conversation

@risikatpopoola
Copy link
Copy Markdown

@risikatpopoola risikatpopoola commented May 30, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This coursework involved writing three articles and trying to match a provided wireframe closely

@netlify
Copy link
Copy Markdown

netlify Bot commented May 30, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 36aec2e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1b6fae0a10840008e0a269
😎 Deploy Preview https://deploy-preview-1378--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@risikatpopoola risikatpopoola added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 30, 2026
cjyuan
cjyuan reviewed May 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error free and page layout looks good. Well done.

I only have two suggestions.

Comment thread Wireframe/style.css
Comment thread Wireframe/index.html Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
@risikatpopoola risikatpopoola added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 30, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 31, 2026

Changes look good.

Code still doesn't look like it's formatted by an automated tool. You may want to double check if it s working as expected.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@risikatpopoola @cjyuan