Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1416
Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1416TTiamiyu wants to merge 1 commit into
Conversation
…, color and also has a submit button
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
TTiamiyu
added
Needs Review
|
@TTiamiyu Since this is a continuation of your previous PR (PR#1257) and not a new PR
|
|
The initial reviewer was tagged in the previous PR before i closed it. |
|
Should I tag the initial reviewer again in the present PR, even if I already tagged in the old PR with the link to this new PR? |
Luro91
added
the
Review in progress
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
I see an accessibility score of 92 in Lighthouse. How can you get it to 100?
| <form> | ||
| <div> | ||
| <label for="name">Name</label> | ||
| <input type="text" name="name" id="name" placeholder="Username" required> |
There was a problem hiding this comment.
What are the requirements for the name and how can you enforce them?
Luro91
added
Reviewed
I found it. As mentioned when you write a short explanation in the PR descriptions it's easier to see as mention link is a bit hidden between the other comments |
3 participants
Learners, PR Template
Self checklist
Changelist
In this commit i have created a form that allows users to select size, color and also has a submit button,