Skip to content

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnRob-jnr wants to merge 3 commits into
base: main
Choose a base branch
from
+55 −22
Open

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
956678e
Revise content in index.html for clarity and relevance in web develop…
JohnRob-jnr Jun 6, 2026
370d54b
Refactor CSS styles for improved layout and readability
JohnRob-jnr Jun 6, 2026
f464a2a
Refactor code structure for improved readability
JohnRob-jnr Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Wireframe/img/Gitbranch1.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/Wireframe1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/readmeimg.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
40 changes: 28 additions & 12 deletions Wireframe/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,41 @@
</head>
<body>
<header>
<h1>Wireframe</h1>
<p>
This is the default, provided code and no changes have been made yet.
</p>
<h1>Web Development & Planning</h1>
<p>Here are some useful steps & information to help you get started with web development.</p>
</header>
<main>
<main>
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<img src="../Wireframe/img/Wireframe1.png" alt="wireframe" />
<h2>Wireframe</h2>
<p>
What is the purpose of a wireframe? Think of "Wireframe" as the Architectural blueprint of a website or App.
A visual guide that outlines the structure, layout and placement of elements on a website.
</p>
<a href="https://www.figma.com/resource-library/what-is-wireframing/">Read more</a>
</article>
<section>
<img src="./img/readmeimg.png" alt="README File" />
<h3>README File</h3>
Comment on lines +23 to +26
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Currently, the first item is an <article> while the other two are <section> elements. Since all three are standalone pieces of content with their own heading, description, image, and link, they should probably all be <article> elements.

  • Since all three topics are siblings, they should use the same heading level.

<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
What is the purpose of a README file? It serves as the introductory guide and instruction manual for a project,
explaining what the software does, how to install and run it, and how others can contribute to it.
</p>
<a href="">Read more</a>
</article>
<a href="https://www.geeksforgeeks.org/git/what-is-readme-md-file/">Read more</a>
</section>
<section>
<img src="./img/Gitbranch1.jpg" alt="Git Branch" />
<h3>Branch in Git</h3>
<p>
What is a branch in Git? A branch in Git is a seperate line of development that allows you to isolate your work,
experiment with new features, fix bugs or make changes without affecting the main codebase.
</p>
<a href="https://github.com/gitstandards/git-branching">Read more</a>
</section>
</main>
<footer>
<p>
This is the default, provided code and no changes have been made yet.
Created By John Robinson. 2026
</p>
</footer>
</body>
Expand Down
37 changes: 27 additions & 10 deletions Wireframe/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,18 @@ As well as useful links to learn more */
--font: 100%/1.5 system-ui;
--space: clamp(6px, 6px + 2vw, 15px);
--line: 1px solid;
--container: 1280px;
--container: 900px;
}
/* ====== Base Elements ======
General rules for basic HTML elements in any context */
body {
background: var(--paper);
color: var(--ink);
font: var(--font);
margin: 0 auto;
text-align: center;
}

a {
padding: var(--space);
border: var(--line);
Expand All @@ -48,12 +51,19 @@ https://www.w3.org/WAI/tutorials/page-structure/regions/
main {
max-width: var(--container);
margin: 0 auto calc(var(--space) * 4) auto;
width: 70%;
text-align: center;
}

footer {
position: fixed;
bottom: 0;
text-align: center;
margin: 0 auto;
padding: 2rem 0;
background-color: white;
width: 100%;
border-top: var(--line);
}

/* ====== Articles Grid Layout ====
Setting the rules for how articles are placed in the main element.
Inspect this in Devtools and click the "grid" button in the Elements view
Expand All @@ -69,21 +79,28 @@ main {
grid-column: span 2;
}
}
header {
text-align: center;
}

article {
border: var(--line);
padding: var(--space);
text-align: left;
}

/* ====== Article Layout ======
Setting the rules for how elements are placed in the article.
Now laying out just the INSIDE of the repeated card/article design.
Keeping things orderly and separate is the key to good, simple CSS.
*/
article {
section {
border: var(--line);
padding-bottom: var(--space);

text-align: left;
display: grid;
grid-template-columns: var(--space) 1fr var(--space);
> * {
grid-column: 2/3;
}
> img {
img {
width: 100%;
grid-column: span 3;
}
Comment on lines +97 to 106
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Could you look up the benefits of using a code formatter? I strongly recommend following this guide
to enable VS Code's "Format on Save" option or use its "Format Document" command. This will help ensure your code is consistently formatted and easier to read and maintain.

}
Loading