london | may2025 | mohammad | aldali | wireframe

[mohammadaldali]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	1ab604e
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/682c5933149d8900085ab26f
😎 Deploy Preview	https://deploy-preview-470--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 97 (🔴 down 3 from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[mohammadaldali]

i hope its match the task

[illicitonion]

This generally looks good, but:

1. The article topics are unexpected - have a read of the requirements for what the three articles are meant to be.
2. The footer isn't centred when it's meant to be, and also it is a bit hard to read the footer when it happens to be scrolled to be in front of some text or images.

Please try to fix those up, otherwise this is looking really good!

[mohammadaldali]

Hi @illictionion 👋

I’ve updated the footer position and adjusted the article topics as you suggested.

Please let me know if everything looks good now, or if anything else needs fixing.

Thanks a lot for your feedback!

[illicitonion]

This looks much better, thanks!

Three small things left:

1. The alt text of the images is now wrong
2. The two bottom articles don't match up in terms of layout. Can you make it so that the image, title, text, and "Read more" button are all aligned between the two articles?
3. The footer covers up the very bottom of the screen (e.g. I can't see the border at the bottom of the git branches article)

[mohammadaldali]

Hi @illictionion 👋
I’ve updated the wireframe project
Please let me know if everything looks good now, or if anything else needs fixing.

Thanks a lot for your feedback!

[illicitonion]

Looks good, thanks so much!