Skip to content

Conversation

@Mahtem
Copy link

@Mahtem Mahtem commented Sep 17, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

The webpage has been designed using different HTML tags so as to display three different articles and styled using
csss styling.

Questions

So far no question.

@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 97281a1
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e12bfd765e2500083b8365
😎 Deploy Preview https://deploy-preview-809--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 89 (🔴 down 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Mahtem Mahtem added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Sep 17, 2025
@Mahtem Mahtem changed the title Manchester | 25-ITP-Sep | Mahtem Mengstu| Sprint 1 | Wireframe to Web Code Manchester|25-ITP-Sep |Mahtem Mengstu|Sprint 1|Wireframe to Web Code Sep 17, 2025
@Mahtem Mahtem changed the title Manchester|25-ITP-Sep |Mahtem Mengstu|Sprint 1|Wireframe to Web Code NW|25-ITP-Sep |Mahtem Mengstu|Sprint 1|Wireframe to Web Code Sep 20, 2025
@Mahtem Mahtem changed the title NW|25-ITP-Sep |Mahtem Mengstu|Sprint 1|Wireframe to Web Code Manchester|25-ITP-Sep |Mahtem Mengstu|Sprint 1|Wireframe to Web Code Sep 20, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 23, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe you need to review the readme to see exactly what this task is asking. We are expecting 3 articles about certain topics

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 23, 2025
@Mahtem
Copy link
Author

Mahtem commented Sep 24, 2025

I think maybe you need to review the readme to see exactly what this task is asking. We are expecting 3 articles about certain topics

Thank you for your efforts, I have now read and prepared according to the requirements in the README file. And have prepared three articles.

@Mahtem Mahtem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted somewhere you could improve code further

</main>

<footer>
<p>For Further Information Please Follow me on <a href="https://github.com/" target="_blank">GitHub</a>.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the acceptance criteria for this task is making sure the footer is fixed to the viewport. Do you know what that means? Can you fix that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have fixed the footer to the view port.

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2025
@Mahtem Mahtem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2025
@LonMcGregor
Copy link

The footer is fixed to the viewport, and the background helps to ensure it is readable.However,now when I scroll all the way to the bottom, it kind of blocks the text and buttons that are there. Can you think of any change to do with the spacing on the page to ensure that when I scroll to the bottom, I can see the full content of the page, while still having the footer visible below that?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 29, 2025
@Mahtem
Copy link
Author

Mahtem commented Oct 3, 2025

The footer is fixed to the viewport, and the background helps to ensure it is readable.However,now when I scroll all the way to the bottom, it kind of blocks the text and buttons that are there. Can you think of any change to do with the spacing on the page to ensure that when I scroll to the bottom, I can see the full content of the page, while still having the footer visible below that?

Thank you. I have tried to make the footer static, so the it stays below main content without overlapping with the texts and buttons. Apologies for my late reply.

@Mahtem Mahtem added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 4, 2025
@LonMcGregor
Copy link

@Mahtem The issue I'm seeing is that the article links are sitting behind the footer. Is there any way to bump them upwards so that when the page is scrolled all the way to the bottom, they are visible?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 4, 2025
@Mahtem
Copy link
Author

Mahtem commented Oct 4, 2025

@Mahtem The issue I'm seeing is that the article links are sitting behind the footer. Is there any way to bump them upwards so that when the page is scrolled all the way to the bottom, they are visible?

@LonMcGregor , Thank you, I have introduced height attributed and made it to be 640px, and the links are now bumped upwards.

@LonMcGregor
Copy link

Great! that works - you are finished with this sprint task now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 4, 2025
@Mahtem
Copy link
Author

Mahtem commented Oct 4, 2025

Great! that works - you are finished with this sprint task now

Thank you so much for your quick replies. Would you please review the following PR too #875? I need to submit it to my Step -1 this night as the deadline is approaching. I would appreciate it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants