-
-
Notifications
You must be signed in to change notification settings - Fork 344
Manchester|25-ITP-Sep |Mahtem Mengstu|Sprint 1|Wireframe to Web Code #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe you need to review the readme to see exactly what this task is asking. We are expecting 3 articles about certain topics
Thank you for your efforts, I have now read and prepared according to the requirements in the README file. And have prepared three articles. |
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this sprint's tasks, I have spotted somewhere you could improve code further
Wireframe/index.html
Outdated
| </main> | ||
|
|
||
| <footer> | ||
| <p>For Further Information Please Follow me on <a href="https://github.com/" target="_blank">GitHub</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the acceptance criteria for this task is making sure the footer is fixed to the viewport. Do you know what that means? Can you fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I have fixed the footer to the view port.
|
The footer is fixed to the viewport, and the background helps to ensure it is readable.However,now when I scroll all the way to the bottom, it kind of blocks the text and buttons that are there. Can you think of any change to do with the spacing on the page to ensure that when I scroll to the bottom, I can see the full content of the page, while still having the footer visible below that? |
Thank you. I have tried to make the footer static, so the it stays below main content without overlapping with the texts and buttons. Apologies for my late reply. |
|
@Mahtem The issue I'm seeing is that the article links are sitting behind the footer. Is there any way to bump them upwards so that when the page is scrolled all the way to the bottom, they are visible? |
@LonMcGregor , Thank you, I have introduced height attributed and made it to be 640px, and the links are now bumped upwards. |
|
Great! that works - you are finished with this sprint task now |
Thank you so much for your quick replies. Would you please review the following PR too #875? I need to submit it to my Step -1 this night as the deadline is approaching. I would appreciate it!! |

Learners, PR Template
Self checklist
Changelist
The webpage has been designed using different HTML tags so as to display three different articles and styled using
csss styling.
Questions
So far no question.