Glasgow | 25-ITP-SEP | Chibuikem Okwu | Sprint 1 | Wireframe #909

chibu0070 · 2025-10-10T23:05:54Z

restarted and triedtomake it follow style guide <!--

You must title your PR like this:

Region | Cohort | FirstName LastName | Sprint | Assignment Title

For example,

London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock

Fill in the template below - remove any sections that don't apply.

Complete the self checklist - replace each empty box in the checklist [ ] with a [x].

Add the label "Needs Review" and you will get review.

Respond to volunteer reviews until the volunteer marks it as "Complete".

-->

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

based on DevTools and Lighthouse feedback

netlify · 2025-10-10T23:05:59Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`76082b2`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68ed1c21d1cd460008cd6b55
😎 Deploy Preview	https://deploy-preview-909--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-10-10T23:06:08Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T23:09:25Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T23:09:30Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T23:09:46Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T23:09:47Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T23:09:50Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T23:09:56Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

to collect name, email, colour and size for a T-shirt order.

github-actions · 2025-10-11T01:47:52Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-11T01:47:53Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jenny-alexander · 2025-10-11T01:54:40Z

Wireframe/index.html

    <main>
      <article>
+        <div>
        <img src="placeholder.svg" alt="" />


All 3 articles should have an image that relates to the article. Right now each image is using:
<img src="placeholder.svg" alt="" />
This is just a placeholder and you should replace with a real image instead.

jenny-alexander · 2025-10-11T01:56:04Z

Wireframe/index.html

+          href="https://www.makeareadme.com/"
+          target="_blank"
+          rel="noopener noreferrer"
+          >Learn more about README files</a


Can you review the wireframe image again?
https://github.com/CodeYourFuture/Module-Onboarding/tree/main/Wireframe#wireframe

Check carefully and see what each article button should be named.

🌱 It's important to follow the wireframe as much as possible.

jenny-alexander · 2025-10-11T01:59:58Z

Wireframe/index.html

The top article's title and description don't match the wireframe alignment. Can you review the wireframe and make the necessary changes?

The title and description match the wireframe now.

jenny-alexander · 2025-10-11T02:04:48Z

Wireframe/index.html

+    </section>
    </main>
+
    <footer>


The footer requirements are:
The page footer is fixed to the bottom of the viewport.

Do you know what 'fixed to the bottom of the viewport' means? It means that the footer is always visible no matter where you scroll to on the page. Right now, when I scroll to the top of the page, the footer disappears.

Good job updating your footer.

github-actions · 2025-10-11T02:08:05Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-11T02:08:07Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

and applied needs review.

jenny-alexander

The wireframe page looks very close to the requirements now. I left a few comments for you to review.

jenny-alexander · 2025-10-11T20:30:49Z

Wireframe/index.html

-        <img src="placeholder.svg" alt="" />
-        <h2>Title</h2>
+        <div>
+        <img src="readme.jpg" alt="" />


Your images now line up nicely with the article's subject. However, I see that the alt tag doesn't have any information. Can you update this? The alt tag is crucial for a screen reader to be able to read out the image description to a blind or low-vision person.

jenny-alexander · 2025-10-11T20:42:06Z

Wireframe/index.html

+      </div>
+      <br>
+     </article>
+


The bottom two article's titles don't quite line up horizontally. Can you review and ensure that their alignment matches the wireframe.
Wireframe requirements: https://github.com/CodeYourFuture/Module-Onboarding/tree/main/Wireframe#wireframe

The alignment is still not quite right. Can you find a way to fix it? Perhaps you can research online how to do this with CSS?

of images in the HTML file.

to the left but it didn't work. I tried different ways but nothing worked. this is what I came up with.

jenny-alexander · 2025-10-12T22:28:49Z

Wireframe/index.html

-        <img src="placeholder.svg" alt="" />
-        <h2>Title</h2>
+        <div>
+        <img src="readme.jpg" alt=Screenshot of a README file example showing project documentation" />


There is a typo in your <img> tag. Can you find it and fix it?

@chibu0070 - the typo still exists on line 21 above. Can you find it within the 'alt' portion of the img tag?

jenny-alexander · 2025-10-12T22:29:18Z

Wireframe/index.html

+      </div>
+      <br>
+     </article>
+


The alignment is still not quite right. Can you find a way to fix it? Perhaps you can research online how to do this with CSS?

deleted aseond <body> tag

jenny-alexander · 2025-10-22T13:11:59Z

@chibu0070 I reviewed your PR again and the 2 issues from a few week's ago are still there. Can you review and fix them?

The <img> tag has a typo in the 'alt' section.
The alignment isn't quite right (see this comment: Glasgow | 25-ITP-SEP | Chibuikem Okwu | Sprint 1 | Wireframe #909 (comment))

chibu0070 added 2 commits October 10, 2025 23:57

Feature/Wireframe: adjust padding and contrast

86cdaba

based on DevTools and Lighthouse feedback

adjusted CSS styl according to leon's comment's

0a860ad

chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Oct 10, 2025

chibu0070 added 3 commits October 11, 2025 00:16

Feature/FormControls: add semantic HTML form

08d1ccf

to collect name, email, colour and size for a T-shirt order.

More changes form control files

20ebe4b

Tested and working code. about to commit.

ef5fe86

chibu0070 mentioned this pull request Oct 11, 2025

Glasgow | 25-ITP-Sep | Onboarding | Chibuikem Okwu chibu0070/My-Coursework-Planner#49

Open

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2025

jenny-alexander self-requested a review October 11, 2025 01:47

jenny-alexander suggested changes Oct 11, 2025

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 11, 2025

All review on Wireframe has been completed

240fa53

and applied needs review.

chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 11, 2025

Reverted form control to default

1073131

jenny-alexander suggested changes Oct 11, 2025

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2025

chibu0070 added 2 commits October 12, 2025 00:46

Created description for the alt attributes

44b5905

of images in the HTML file.

Tried to align the grid in the article div

f4a2907

to the left but it didn't work. I tried different ways but nothing worked. this is what I came up with.

chibu0070 requested a review from jenny-alexander October 12, 2025 00:25

chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 12, 2025

jenny-alexander suggested changes Oct 12, 2025

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 12, 2025

Used prettier to format code on save also

76082b2

deleted aseond <body> tag

chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 13, 2025

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 22, 2025

Uh oh!

Glasgow | 25-ITP-SEP | Chibuikem Okwu | Sprint 1 | Wireframe #909

Are you sure you want to change the base?

Glasgow | 25-ITP-SEP | Chibuikem Okwu | Sprint 1 | Wireframe #909

Uh oh!

Conversation

chibu0070 commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Uh oh!

netlify bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 11, 2025

Uh oh!

github-actions bot commented Oct 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 11, 2025

Uh oh!

github-actions bot commented Oct 11, 2025

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chibu0070 commented Oct 10, 2025 •

edited

Loading

netlify bot commented Oct 10, 2025 •

edited

Loading