Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 2 | Form Controls#978
Closed
marthak1 wants to merge 10 commits intoCodeYourFuture:mainfrom
Closed
Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 2 | Form Controls#978marthak1 wants to merge 10 commits intoCodeYourFuture:mainfrom
marthak1 wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
…t email validation
…s the required alt meaninigful
…tual color selection
…ed to avoid accidental checking
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
marthak1
added
the
Needs Review
cjyuan
reviewed
Jan 18, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Lighthouse score is 93/100.
- Reason: Touch targets do not have sufficient size or spacing.
-
Consider aligning the wording used in the legend so similar items are described consistently. This helps users understand the information more quickly.
Customer Details
T-Shirt Color Preference
Choose Your T-Shirt Size
- In the PR description, to create list items in Markdown, we need to leave a space between
-and the text.
Comment on lines
+22
to
+23
| <input type="text" id="name" name="name" minlength="3" maxlength="15" autocomplete="name" | ||
| placeholder="enter your name" required> |
Contributor
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
Author
There was a problem hiding this comment.
Thank for pointing this out. I hadn't considered that scenario.
Author
There was a problem hiding this comment.
These changes has now been applied.
cjyuan
added
Reviewed
…for stricter name validation - aligned legend wordings for consistency
marthak1
added
the
Needs Review
Contributor
|
Looks good. |
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Summary
This project demonstrates basic HTML form validation
Changes
References
Sprint 2 Backlog – Task: Form Controls