fix(PopoverContainer): working in RTL #3333
Merged
LinKCoding merged 10 commits intocass-gmt-1601from Apr 29, 2026
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit d76da5a ☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cass-gmt-1601 #3333 +/- ##
=================================================
+ Coverage 89.25% 89.31% +0.06%
=================================================
Files 251 251
Lines 4719 4755 +36
Branches 1570 1619 +49
=================================================
+ Hits 4212 4247 +35
- Misses 499 500 +1
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LinKCoding
force-pushed
the
kl-gmt-1598-popovercontainer-alignment
branch
from
c91d7f0 to
a1befa9
Compare
LinKCoding
force-pushed
the
kl-gmt-1598-popovercontainer-alignment
branch
from
a1befa9 to
a7779c6
Compare
dreamwasp
reviewed
Apr 29, 2026
|
|
||
| const { dirNeutralStyles, styles: placementStyles } = popoverPosition; | ||
|
|
||
| /** Non-empty `placementStyles` merged into inline `style`; `dirNeutralStyles` layered last (see `getPosition`). */ |
Contributor
There was a problem hiding this comment.
this is the tiniest nit ever but could you swap to the same comment style as the one above?
/** Line one
- two
**/
dreamwasp
approved these changes
Apr 29, 2026
Contributor
dreamwasp
left a comment
dreamwasp
left a comment
There was a problem hiding this comment.
looke great in SB, testing mono now
Collaborator
|
📬 Published Alpha Packages:
|
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://69f20efca272a71d5815cec3--gamut-preview.netlify.app |
dreamwasp
added a commit
that referenced
this pull request
Apr 29, 2026
* chore(GamutProvider): useLogicalProperties hook * feat(gamut-styles): add directionIsRtl utility Move DOM direction resolution (including JSDOM fallback) into @codecademy/gamut-styles utilities and export alongside useLogicalProperties. * fix(InfoTip): update rtl styles (#3319) * bug(InfoTip): update rtl styles Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com> * fix(InfoTip): update rtl styles (#3319) * bug(InfoTip): update rtl styles Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com> * Update packages/styleguide/src/lib/Meta/Logical and physical CSS properties.mdx Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com> * fix(Pagination): Previous and Next Buttons to respect RTL (#3316) * chore: Update SelectDropdown Multi select to use logical properties (#3331) * fix: popover alignment for rtl / useLogicalProperties (#3326) * fix: popover, need to test invertAxis * fix: Address followups for ToolTip bugs RTL (#3330) * fix(Popover): addressing left/right beak (#3332) Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com> * fix(PopoverContainer): working in RTL (#3333) * using physical properties for PopoverContainer positioning, mirroring is manual * fix tests --------- Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates PopoverContainer to revert back to use physical properties in lieu of logical properties.
The major constraint was how logical properties flip (or double-flip) and do not work with the math involved in positioning a PopoverContainer.
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs