Merged
Conversation
Contributor
vytisbulkevicius
commented
Mar 3, 2026
vytisbulkevicius
commented
- Enhanced security
Fix nullable type declaration
* [wip]: save progress * experiment: security audit (#1250) * experiment: security audit * fix: failing e2e tests * chore: remove old cypress tests * chore: bump php version for lint
Restricted chart creation wizard
Contributor
Prevent unauthorized users from updating chart data
Improved nonce creation
Added WooCommerce request verification token
Prevent cross site scripting
Contributor
Author
|
UPDATE: Fixed it. @girishpanchal30 with this build where security fixes are merged it's not possible to create a new chart - the popup of creating a chart always refreshes when clicking next. Please check |
The security PR that was merged to development added nonce action
parameters to nonce creation and uploadData verification, but forgot
to update _handleTypesPage verification. This caused a mismatch where:
- Nonces were created WITH action: wp_create_nonce('visualizer-upload-data')
- But _handleTypesPage verified WITHOUT action: wp_verify_nonce($nonce)
- Result: Nonce verification failed, chart creation broken
This fix updates _handleTypesPage to verify WITH the action parameter
to match the nonce creation, allowing charts to be created successfully
while maintaining all security improvements.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Layout.php line 983 was unconditionally accessing Visualizer_Pro::ACTION_FETCH_DATA even in the free version, causing a fatal error when creating charts. The nonce creation now checks if PRO version is active before accessing the Visualizer_Pro class, matching the pattern used for the action parameter. Security fix from previous commit remains intact: - Chart.php line 958: Nonce verification with 'visualizer-upload-data' action - uploadData() method: Capability checks and per-chart ownership validation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed incorrect case usage: Visualizer_PRO -> Visualizer_Pro This resolves the PHPStan check failure that was blocking CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…e-clean Fix chart creation nonce verification mismatch
Contributor
|
🎉 This PR is included in version 3.11.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.