fix(exporter): ensure string and fret for all staff types - #2832
Merged
Conversation
# Conflicts: # packages/alphatab/src/exporter/GpifWriter.ts # packages/alphatab/src/importer/MusicXmlImporter.ts # packages/alphatab/src/model/ModelUtils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2827
Proposed changes
Quite a major rework how we assign
note.stringandnote.fretto notes. GP7 and GP8 now require again string and fret to be set for all staves. The Pitched-only staves were a temporary GP6 thing only.This PR lays the foundation for inferring tablature for pitched staves.
As a side fix also the whole percussion export was checked again to ensure correct notes will be shown in GP8.
Checklist
AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details