Skip to content

React 0.13 Update#2

Closed
malonecj wants to merge 39 commits intomasterfrom
cm-react013-upgrade
Closed

React 0.13 Update#2
malonecj wants to merge 39 commits intomasterfrom
cm-react013-upgrade

Conversation

@malonecj
Copy link
Copy Markdown
Contributor

@malonecj malonecj commented Apr 4, 2015

  • Upgrade React
  • Fix issues due to breaking changes
  • Es6 class editors
    • Editor Base class
    • SimpleTextEditor extending EditorBase
    • DropDownEditor extending EditorBase
    • Autocomplete editor extending EditorBase
    • Editor container tests

react-data-grid

Comment thread src/addons/editors/SimpleTextEditor.js Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bakesteve, got bored in Ireland over Easter. Have simplified the editors. No longer have to worry about binding onKeyDown as this is taken care of in EditorContainer unless you want to override default behaviour

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (to the work, not getting bored…!)

@bakesteve bakesteve mentioned this pull request Jul 17, 2015
@theTechie
Copy link
Copy Markdown

@acr92
Copy link
Copy Markdown

acr92 commented Aug 6, 2015

Any chance this can/will be merged/finished soon?

@malonecj
Copy link
Copy Markdown
Contributor Author

I've been a bit stuck for time at the moment. But have not forgotten about this. It is practically finished. There are still some failing tests and the autocomplete edtior needs to be complete. Hope to get around to it soon

@jbrodriguez
Copy link
Copy Markdown

Hi @malonecj, nice library !

Can you ship a pre/alpha/beta without autocomplete for the time being ?

I tried installing with npm install git://github.com/adazzle/react-data-grid.git#cm-react013-upgrade, but it fails saying it didn't find ./dist/react-data-grid.

The dist folder isn't there.

@malonecj
Copy link
Copy Markdown
Contributor Author

Hi yes

This will be on its ways in the next couple of days.

Thanks

On 27 August 2015 at 20:09, Juan B. Rodriguez notifications@github.com
wrote:

Hi @malonecj https://github.com/malonecj, nice library !

Can you ship a pre/alpha/beta without autocomplete for the time being ?

I tried installing with npm install git://
github.com/adazzle/react-data-grid.git#cm-react013-upgrade, but it fails
saying it didn't find ./dist/react-data-grid.

The dist folder isn't there.


Reply to this email directly or view it on GitHub
#2 (comment)
.

@aidanlister
Copy link
Copy Markdown

Exciting

@malonecj
Copy link
Copy Markdown
Contributor Author

malonecj commented Sep 1, 2015

Hi all

I've published a pre release version 0.13.0-alpha1

The autocomplete is working, but there are still two failing tests at the moment. I'll try to pick those up soon or feel free anyone to step in.

@malonecj
Copy link
Copy Markdown
Contributor Author

@bakesteve Build passing along with all tests now.

malonecj pushed a commit that referenced this pull request Sep 17, 2015
@malonecj malonecj closed this Sep 17, 2015
@malonecj malonecj deleted the cm-react013-upgrade branch September 17, 2015 11:16
maieutiquer added a commit to maieutiquer/react-data-grid that referenced this pull request Jan 9, 2018
Merge Upstream, add gridName class to container, fix Select All checkbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants