[WIP] Feat: Maintain archetype-catalog.xml for Maven #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat: Maintain sha1, md5, and sha256 files for maven-metadata.xml NOTE: The tests are VERY broken currently. I haven't figured out why yet.
|
This pull request introduces 3 alerts when merging 5a59d66 into c6b8b96 - view on LGTM.com new alerts:
|
ligangty
reviewed
Dec 7, 2021
|
|
||
| uploaded_files = [] | ||
|
|
||
| def get_file_digest(path: str, hashtype: str) -> str: |
Member
There was a problem hiding this comment.
We have a similar func in charon.utils.files, maybe we should re-use it by some modification.
| ) | ||
|
|
||
| if digests: | ||
| bucket.Object(full_file_path + ".sha1").put( |
Member
There was a problem hiding this comment.
I think these are only needed for maven pkg(maven-metadata.xml, archetype-catalog.xml), right? So maybe a better way is extracted these logic to charon.pkgs.maven module, but not in the storage module. I'll check how to change this today.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Maintain sha1, md5, and sha256 files for maven-metadata.xml
NOTE: The tests are VERY broken currently. I haven't figured out why yet.