[WIP] Feat: Maintain archetype-catalog.xml for Maven #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging ae56034 into 6681ed8 - view on LGTM.com new alerts:
|
Pull Request Test Coverage Report for Build 1549104873
💛 - Coveralls |
Feat: Maintain sha1, md5, and sha256 files for maven-metadata.xml NOTE: The tests are VERY broken currently. I haven't figured out why yet.
* archetype-catalog digest files generation in maven.py * some test failure fix
maven_del tests and maven_index tests
|
This pull request introduces 1 alert when merging 6ddf058 into 7ed1285 - view on LGTM.com new alerts:
|
jdcasey
requested changes
Dec 7, 2021
Member
jdcasey
left a comment
jdcasey
left a comment
There was a problem hiding this comment.
I'll try to take a look at the changes I identified in this review, and see if I can update / resubmit the patch. Just a note...if we use a feature branch on the main repository, then we can collaborate on the PR to resolve this kind of stuff. I'm not sure of the downside for that kind of thing, but we should explore it.
jdcasey
approved these changes
Dec 7, 2021
Member
jdcasey
left a comment
jdcasey
left a comment
There was a problem hiding this comment.
I missed the call to setup the full list of files to upload for archetype-catalog.xml. It does look complete, sorry for the confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.