docs(challenge-06): add missing Create pull request step on the compare page#247
Conversation
…re page A learner following Challenge 6 reached the compare view and found no title or description form because the instructions jump from choosing base and compare straight to writing a title (support#60). Add the intermediate Create pull request button step with screen reader navigation hints, explain why the comparison preview reads long, and add a matching row to the stuck table and the chapter's screen reader tool card. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Learning Room Validation ReportGreat work. Your changes look good. Resources |
|
Hi! I am Gandalf, your workshop agent. I bring a little magic to make this interaction clear, helpful, and fun. Here is my review of your pull request: Report StatusValidation Needs Attention [ACTION REQUIRED] Required Checks
Learning ResourcesBased on your changes, these guides might help: Automated validation by Learning Room Bot. Gandalf generated this review. Last updated: 2026-07-05T02:45:26.850Z |
github-actions
Bot
added
documentation
Progress UpdateGreat work, @accesswatch! Current Level: Explorer Available Challenges:
Keep going! |
Peer Review AssignedHi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review. For @taylorarndt:This is a great opportunity to practice code review skills! Here's what to look for: Content Quality:
Accessibility:
Documentation:
Review Guidelines:
Resources: Pairing by Learning Room Grouping Engine |
There was a problem hiding this comment.
Pull request overview
This PR closes an instruction gap in Challenge 6 and Chapter 6 documentation by explicitly telling learners to activate the Create pull request button on the compare page before expecting the PR title/description form to appear, with added navigation hints for screen reader users.
Changes:
- Adds a missing “Activate Create pull request” step (and “long preview is normal” context) to Challenge 6 learner instructions and the issue template.
- Updates Chapter 6 screen reader instructions to include the missing activation step when opening a PR from a branch.
- Regenerates committed HTML outputs (including search index) to reflect the Markdown/template updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| work.md | Adds the missing “Create pull request” activation step and a new stuck-case row for missing PR form fields. |
| learning-room/.github/ISSUE_TEMPLATE/challenge-06-first-pr.yml | Updates the Challenge 6 issue form instructions to include the missing compare-page button step and troubleshooting row. |
| docs/06-working-with-pull-requests.md | Adds the missing compare-page “Create pull request” activation step for NVDA/JAWS screen reader instructions. |
| html/work.html | Regenerated HTML for work.md to include the updated Challenge 6 steps and troubleshooting row. |
| html/search-index.json | Regenerated search index to reflect updated documentation content. |
| html/docs/06-working-with-pull-requests.html | Regenerated HTML for Chapter 6 to include the updated NVDA/JAWS instruction step. |
| 2. A "Compare & pull request" banner may appear (if you recently pushed) - activate it | ||
| 3. OR: Navigate to Pull Requests tab → "New pull request" | ||
| 4. Choose your base branch (what to merge into) and compare branch (your changes) | ||
| 5. Activate the **Create pull request** button. It sits between the branch choosers and the diff, and the title and description form appears only after you activate it. Use the button quick navigation key (B in NVDA and JAWS browse mode) or search the page for "Create pull request". The comparison preview can read as very long because it includes unchanged context lines - the form is above it, not below it. |
Fixes the instruction gap behind Community-Access/support#60.
Challenge 6 told learners to set base and compare and then write a PR title, but the title and description form only appears after activating the Create pull request button on the compare page. A screen reader user reading the long comparison preview had no way to discover that step.
Changes:
Validation: npm run build:html and npm run validate:authoritative-sources both pass.
Follow-up (not in this PR): sync the template change to learning-room-template and the cohort rooms.
🤖 Generated with Claude Code