Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/06-working-with-pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,7 @@ gh pr create --title "Your title" --body "Description"
2. A "Compare & pull request" banner may appear (if you recently pushed) - activate it
3. OR: Navigate to Pull Requests tab → "New pull request"
4. Choose your base branch (what to merge into) and compare branch (your changes)
5. Activate the **Create pull request** button. It sits between the branch choosers and the diff, and the title and description form appears only after you activate it. Use the button quick navigation key (B in NVDA and JAWS browse mode) or search the page for "Create pull request". The comparison preview can read as very long because it includes unchanged context lines - the form is above it, not below it.

</details>

Expand Down
1 change: 1 addition & 0 deletions html/docs/06-working-with-pull-requests.html
Original file line number Diff line number Diff line change
Expand Up @@ -1149,6 +1149,7 @@ <h3 id="from-a-fork-or-feature-branch">From a fork or feature branch</h3>
<li>A &quot;Compare &amp; pull request&quot; banner may appear (if you recently pushed) - activate it</li>
<li>OR: Navigate to Pull Requests tab → &quot;New pull request&quot;</li>
<li>Choose your base branch (what to merge into) and compare branch (your changes)</li>
<li>Activate the <strong>Create pull request</strong> button. It sits between the branch choosers and the diff, and the title and description form appears only after you activate it. Use the button quick navigation key (B in NVDA and JAWS browse mode) or search the page for &quot;Create pull request&quot;. The comparison preview can read as very long because it includes unchanged context lines - the form is above it, not below it.</li>
</ol>
</details>

Expand Down
24 changes: 12 additions & 12 deletions html/search-index.json

Large diffs are not rendered by default.

9 changes: 7 additions & 2 deletions html/work.html
Original file line number Diff line number Diff line change
Expand Up @@ -591,10 +591,11 @@ <h4 id="instructions">Instructions</h4>
<ol>
<li>Go to the <strong>Pull requests</strong> tab.</li>
<li>Select <strong>New pull request</strong>.</li>
<li>Set <strong>base</strong> to <code>main</code> and <strong>compare</strong> to <code>learn/YOUR-USERNAME</code>.</li>
<li>Set <strong>base</strong> to <code>main</code> and <strong>compare</strong> to <code>learn/YOUR-USERNAME</code>. The page shows a preview of your commits and changed files. This preview can read as very long because it includes unchanged context lines around each change - that is normal.</li>
<li>Activate the <strong>Create pull request</strong> button. It sits between the branch choosers and the diff, and the title and description fields do not appear until you activate it. With a screen reader, use the button quick navigation key (B in NVDA and JAWS browse mode) or search the page for &quot;Create pull request&quot;.</li>
<li>Write a descriptive PR title.</li>
<li>In the PR description, include <code>Closes #XX</code> (replace XX with your Challenge 2 issue number). This automatically links and closes the issue when the PR is merged.</li>
<li>Submit the pull request.</li>
<li>Submit by activating the <strong>Create pull request</strong> button below the description field.</li>
</ol>
<h4 id="pr-description-template">PR description template</h4>
<p>Use this structure for your PR description:</p>
Expand Down Expand Up @@ -638,6 +639,10 @@ <h4 id="if-you-get-stuck">If you get stuck</h4>
<td>Make sure you are on the Pull requests tab. The button is near the top-right.</td>
</tr>
<tr>
<td>The diff appears but there is no title or description field</td>
<td>The compare page shows only a preview at first. Activate the <strong>Create pull request</strong> button between the branch choosers and the diff to open the form.</td>
</tr>
<tr>
<td>It says &quot;There isn&#39;t anything to compare&quot;</td>
<td>Make sure your branch has at least one commit that differs from main. Did you commit to the right branch?</td>
</tr>
Expand Down
10 changes: 6 additions & 4 deletions learning-room/.github/ISSUE_TEMPLATE/challenge-06-first-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@ body:

1. Go to the **Pull requests** tab.
2. Select **New pull request**.
3. Set **base** to `main` and **compare** to `learn/YOUR-USERNAME`.
4. Write a descriptive PR title.
5. In the PR description, include `Closes #XX` (replace XX with your Challenge 2 issue number). This automatically links and closes the issue when the PR is merged.
6. Submit the pull request.
3. Set **base** to `main` and **compare** to `learn/YOUR-USERNAME`. The page shows a preview of your commits and changed files. This preview can read as very long because it includes unchanged context lines around each change - that is normal.
4. Activate the **Create pull request** button. It sits between the branch choosers and the diff, and the title and description fields do not appear until you activate it. With a screen reader, use the button quick navigation key (B in NVDA and JAWS browse mode) or search the page for "Create pull request".
5. Write a descriptive PR title.
6. In the PR description, include `Closes #XX` (replace XX with your Challenge 2 issue number). This automatically links and closes the issue when the PR is merged.
7. Submit by activating the **Create pull request** button below the description field.

### PR description template

Expand Down Expand Up @@ -66,6 +67,7 @@ body:
| Symptom | Try this |
|---|---|
| I cannot find the New pull request button | Make sure you are on the Pull requests tab. The button is near the top-right. |
| The diff appears but there is no title or description field | The compare page shows only a preview at first. Activate the **Create pull request** button between the branch choosers and the diff to open the form. |
| It says "There isn't anything to compare" | Make sure your branch has at least one commit that differs from main. Did you commit to the right branch? |
| I forgot to include `Closes #XX` | Edit your PR description after creating it. Select the three-dot menu or the Edit button on the description. |
| I finished but want to check my work | [View the reference solution](https://github.com/Community-Access/git-going-with-github/blob/main/docs/solutions/solution-06-first-pr.md) |
10 changes: 6 additions & 4 deletions work.md
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,11 @@ Source template: [challenge-06-first-pr.yml](https://github.com/Community-Access

1. Go to the **Pull requests** tab.
2. Select **New pull request**.
3. Set **base** to `main` and **compare** to `learn/YOUR-USERNAME`.
4. Write a descriptive PR title.
5. In the PR description, include `Closes #XX` (replace XX with your Challenge 2 issue number). This automatically links and closes the issue when the PR is merged.
6. Submit the pull request.
3. Set **base** to `main` and **compare** to `learn/YOUR-USERNAME`. The page shows a preview of your commits and changed files. This preview can read as very long because it includes unchanged context lines around each change - that is normal.
4. Activate the **Create pull request** button. It sits between the branch choosers and the diff, and the title and description fields do not appear until you activate it. With a screen reader, use the button quick navigation key (B in NVDA and JAWS browse mode) or search the page for "Create pull request".
5. Write a descriptive PR title.
6. In the PR description, include `Closes #XX` (replace XX with your Challenge 2 issue number). This automatically links and closes the issue when the PR is merged.
7. Submit by activating the **Create pull request** button below the description field.

#### PR description template

Expand Down Expand Up @@ -363,6 +364,7 @@ Find the **Peer Simulation: Improve contribution guidance** PR and leave an enco
| Symptom | Try this |
|---|---|
| I cannot find the New pull request button | Make sure you are on the Pull requests tab. The button is near the top-right. |
| The diff appears but there is no title or description field | The compare page shows only a preview at first. Activate the **Create pull request** button between the branch choosers and the diff to open the form. |
| It says "There isn't anything to compare" | Make sure your branch has at least one commit that differs from main. Did you commit to the right branch? |
| I forgot to include `Closes #XX` | Edit your PR description after creating it. Select the three-dot menu or the Edit button on the description. |
| I finished but want to check my work | [View the reference solution](https://github.com/Community-Access/git-going-with-github/blob/main/docs/solutions/solution-06-first-pr.md) |
Expand Down
Loading