Added "file:///" to the "location" attribute of "sourceFile" element … #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when converting to .mzml format to avoid problems identifying URI format when using relative path.
Contributor
|
This is also in alignment with the official spec :) Thanks @CarlosHorro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when converting to .mzml format to avoid problems identifying URI format when using relative path.
Search engines as MetaMorpheus do not properly identify the format of relative paths like "./raws_folder/input.raw"
and they crash just reading the .mzml even when they do not use the raw file itself.
We have experienced this problem when using .mzml files generated by ThermoRawFileConverter in galaxy as galaxy uses with the "-d" argument the relative path to its working folder "./raws_folder".
Just adding "file:///" to this relative path is enought to properly identify the type of the provided URI.
Greetings,
Carlos