Skip to content

CNF-22646: Fix typos in error variable names - #1118

Open
sebrandon1 wants to merge 1 commit into
ComplianceAsCode:masterfrom
sebrandon1:cleanup/fix-error-typos
Open

CNF-22646: Fix typos in error variable names#1118
sebrandon1 wants to merge 1 commit into
ComplianceAsCode:masterfrom
sebrandon1:cleanup/fix-error-typos

Conversation

@sebrandon1

@sebrandon1 sebrandon1 commented Mar 26, 2026

Copy link
Copy Markdown

Summary

  • Fix typos in error variable names: ErrUnkownScanType -> ErrUnknownScanType, ErrUnkownScanerType -> ErrUnknownScannerType
  • No behavioral changes

Related PRs

PR Title Status
#1116 CNF-22644: Remove unused functions, variables, and struct fields Open
#1117 CNF-22645: Use strings.EqualFold for case-insensitive comparisons Open
#1119 CNF-22647: Rename KubeDepsNotFound to ErrKubeDepsNotFound Open
#1120 CNF-22657: Replace deprecated io/ioutil with io package Open
#1121 CNF-22658: Remove deprecated GO111MODULE=auto from Makefile Open
#1122 CNF-22659: Fix typo in error message: retriving -> retrieving Open
#1123 CNF-22660: Lowercase error strings per Go conventions Open
#721 CNF-22754: Update repository references from openshift to ComplianceAsCode org Open
#1187 CNF-23094: Propagate context through pkg/utils public API Open

Jira

  • CNF-22646 -- Fix typos in error variable names (Code Review)
  • Epic: CNF-23313 -- Compliance Operator Tuning

Test Plan

  • CI passes
  • Existing tests pass without modification

@openshift-ci

openshift-ci Bot commented Mar 26, 2026

Copy link
Copy Markdown

Hi @sebrandon1. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sebrandon1 sebrandon1 changed the title Fix typos in error variable names CNF-22646: Fix typos in error variable names Mar 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Collaborator

@sebrandon1: This pull request references CNF-22646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • ErrUnkownScanTypeErrUnknownScanType
  • ErrUnkownScanerTypeErrUnknownScannerType

Test plan

  • make verify passes
  • make test-unit passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-f32e93e8a9ed738d3fe65ed3b3b3fe32ca984799

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from f32e93e to bbe6ae1 Compare April 6, 2026 18:28
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-bbe6ae17e2c5d2d9d1ddba9c695359bf2a78e9cc

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from bbe6ae1 to 1dbbb96 Compare April 14, 2026 20:56
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-1dbbb965d23e44ad24c9b2b3a61fc901d414bda0

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 1dbbb96 to 29e5b3c Compare April 20, 2026 19:22
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-29e5b3c5538980e98d9af16c20d458bed0466f6a

@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-51772038e1fb262c01d2edaceac3bedbe5c1e2e4

@sebrandon1

Copy link
Copy Markdown
Author

@yuumasato Could you please /ok-to-test this PR when you get a chance? Thanks!

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 5177203 to 83a3375 Compare May 29, 2026 14:59
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-83a337579229e153c3fd7e3e2da0b20cd67d9d03

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 83a3375 to 7e44189 Compare June 5, 2026 16:19
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-7e4418990ab47e2f3d9f20065154c0acaa516b82

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 7e44189 to 02c7ec4 Compare June 10, 2026 18:55
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-02c7ec4072796e81951baf851ef2905fb48f7938

@sebrandon1

Copy link
Copy Markdown
Author

@yuumasato Could you please /ok-to-test this PR when you get a chance? Thanks!

@yuumasato

Copy link
Copy Markdown
Member

/ok-to-test

@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-37573f6b3ccd5f9da2e1b227a8c5cbfbb47b9311

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 37573f6 to 3bb432e Compare June 18, 2026 17:41
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-3bb432e46d0198069159c2ac5e2f7cb18248eb98

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 3bb432e to 43a5fc6 Compare June 26, 2026 18:04
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-43a5fc6ec354c44afdfe39ef287bbbe0cb545552

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 43a5fc6 to d7c3f58 Compare June 29, 2026 15:40
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-d7c3f58e59e53d060b5b138affe1448285ac3cdb

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from d7c3f58 to 7f82d46 Compare July 6, 2026 16:14
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-7f82d465079672cb08f80ead847d6ae890efa6cd

@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 7f82d46 to 41c4dc4 Compare July 23, 2026 18:03
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-config 3bb432e link true /test e2e-aws-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- ErrUnkownScanType → ErrUnknownScanType
- ErrUnkownScanerType → ErrUnknownScannerType
@sebrandon1
sebrandon1 force-pushed the cleanup/fix-error-typos branch from 41c4dc4 to e2cf464 Compare August 5, 2026 19:15
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign mrogers950 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@sebrandon1: This pull request references CNF-22646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Fix typos in error variable names: ErrUnkownScanType -> ErrUnknownScanType, ErrUnkownScanerType -> ErrUnknownScannerType
  • No behavioral changes

Related PRs

PR Title Status
#1116 CNF-22644: Remove unused functions, variables, and struct fields Open
#1117 CNF-22645: Use strings.EqualFold for case-insensitive comparisons Open
#1119 CNF-22647: Rename KubeDepsNotFound to ErrKubeDepsNotFound Open
#1120 CNF-22657: Replace deprecated io/ioutil with io package Open
#1121 CNF-22658: Remove deprecated GO111MODULE=auto from Makefile Open
#1122 CNF-22659: Fix typo in error message: retriving -> retrieving Open
#1123 CNF-22660: Lowercase error strings per Go conventions Open
#721 CNF-22754: Update repository references from openshift to ComplianceAsCode org Open
#1187 CNF-23094: Propagate context through pkg/utils public API Open

Jira

  • CNF-22646 -- Fix typos in error variable names (Code Review)
  • Epic: CNF-23313 -- Compliance Operator Tuning

Test Plan

  • CI passes
  • Existing tests pass without modification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1118-e2cf4644e7a3fc7a869c81b59383df934917492b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants