CNF-22658: Remove deprecated GO111MODULE=auto from Makefile by sebrandon1 · Pull Request #1121 · ComplianceAsCode/compliance-operator

sebrandon1 · 2026-03-26T13:28:55Z

Summary

Remove GO111MODULE=auto from Makefile -- it has been a no-op since Go 1.21+ where module mode is always enabled
The project uses Go 1.25; no behavioral changes

Related PRs

PR	Title	Status
#1116	CNF-22644: Remove unused functions, variables, and struct fields	Open
#1117	CNF-22645: Use strings.EqualFold for case-insensitive comparisons	Open
#1118	CNF-22646: Fix typos in error variable names	Open
#1119	CNF-22647: Rename KubeDepsNotFound to ErrKubeDepsNotFound	Open
#1120	CNF-22657: Replace deprecated io/ioutil with io package	Open
#1122	CNF-22659: Fix typo in error message: retriving -> retrieving	Open
#1123	CNF-22660: Lowercase error strings per Go conventions	Open
#721	CNF-22754: Update repository references from openshift to ComplianceAsCode org	Open
#1187	CNF-23094: Propagate context through pkg/utils public API	Open

Jira

CNF-22658 -- Remove deprecated GO111MODULE=auto from Makefile (Code Review)
Epic: CNF-23313 -- Compliance Operator Tuning

Test Plan

CI passes
Existing tests pass without modification

openshift-ci-robot · 2026-03-26T13:29:00Z

@sebrandon1: This pull request references CNF-22658 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Remove GO111MODULE=auto from Makefile — it has been a no-op since Go 1.21+ where module mode is always enabled

The project uses Go 1.25

CNF-22658

Test plan

make verify passes

make test-unit passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-26T13:29:07Z

Hi @sebrandon1. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

github-actions · 2026-03-26T13:37:21Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-79bd3fd47f52da337f385590129d4513e0a36e64

github-actions · 2026-04-06T18:41:54Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-cf64c3dd9fd1eb94c7a13c20c591e68e802ed61c

github-actions · 2026-04-14T21:10:02Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-06511fd0d1397be0c657937c78dfc483e0695a52

github-actions · 2026-04-20T19:35:00Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-463ef74d8f77277855824d4c6c9471940d0e9d56

github-actions · 2026-04-27T22:27:54Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-0e1d8aef9cffd6930c68f3268969deedfde60315

sebrandon1 · 2026-05-04T19:15:34Z

@yuumasato Could you please /ok-to-test this PR when you get a chance? Thanks!

github-actions · 2026-05-29T16:55:46Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-14d6b04a6223ede86794f1a7d5d5966f4eafaba4

github-actions · 2026-06-05T16:32:49Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-87fa9332ec5099b96504a3d9d86192b75992ea34

github-actions · 2026-06-10T19:13:21Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-20418f296b6d53e04aa2f07cf5ade94a78d849d3

sebrandon1 · 2026-06-10T20:16:33Z

@yuumasato Could you please /ok-to-test this PR when you get a chance? Thanks!

yuumasato · 2026-06-10T22:58:23Z

/ok-to-test

github-actions · 2026-06-15T17:33:51Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-4410650e164f17a12d0c60546e2d718c9d5b6348

github-actions · 2026-06-18T17:56:50Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-b7128480a849fdd8c470260195fb252bb7fc405e

github-actions · 2026-06-26T18:17:52Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-5aab2a7c85f9d948ef7aa13870731d3147995241

github-actions · 2026-06-29T15:54:21Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-d4e00863dbbefb0452bff257dd379a137ea37165

github-actions · 2026-07-06T16:33:35Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-f06ca3b7ac9d807a146116be8bbaca8de5797a52

GO111MODULE=auto has been a no-op since Go 1.21+ where module mode is always enabled. The project uses Go 1.25.

openshift-ci · 2026-08-05T19:16:23Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign mrogers950 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-08-05T19:28:05Z

@sebrandon1: This pull request references CNF-22658 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Remove GO111MODULE=auto from Makefile -- it has been a no-op since Go 1.21+ where module mode is always enabled

The project uses Go 1.25; no behavioral changes

Related PRs

PR Title Status

#1116 CNF-22644: Remove unused functions, variables, and struct fields Open

#1117 CNF-22645: Use strings.EqualFold for case-insensitive comparisons Open

#1118 CNF-22646: Fix typos in error variable names Open

#1119 CNF-22647: Rename KubeDepsNotFound to ErrKubeDepsNotFound Open

#1120 CNF-22657: Replace deprecated io/ioutil with io package Open

#1122 CNF-22659: Fix typo in error message: retriving -> retrieving Open

#1123 CNF-22660: Lowercase error strings per Go conventions Open

#721 CNF-22754: Update repository references from openshift to ComplianceAsCode org Open

#1187 CNF-23094: Propagate context through pkg/utils public API Open

Jira

CNF-22658 -- Remove deprecated GO111MODULE=auto from Makefile (Code Review)

Epic: CNF-23313 -- Compliance Operator Tuning

Test Plan

CI passes

Existing tests pass without modification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

github-actions · 2026-08-05T19:46:58Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1121-1163da708ce0d40947feeadf6440f682b4e8e1be

openshift-ci · 2026-08-05T21:23:00Z

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-config	`b712848`	link	true	`/test e2e-aws-config`
ci/prow/e2e-rosa	`d4e0086`	link	true	`/test e2e-rosa`
ci/prow/e2e-aws-deployment	`d4e0086`	link	true	`/test e2e-aws-deployment`
ci/prow/e2e-aws-parallel	`1163da7`	link	true	`/test e2e-aws-parallel`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference label Mar 26, 2026

openshift-ci Bot requested review from Vincent056 and jhrozek March 26, 2026 13:28

openshift-ci Bot added the needs-ok-to-test label Mar 26, 2026

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 79bd3fd to cf64c3d Compare April 6, 2026 18:29

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from cf64c3d to 06511fd Compare April 14, 2026 20:57

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 06511fd to 463ef74 Compare April 20, 2026 19:22

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 463ef74 to 0e1d8ae Compare April 27, 2026 22:15

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 0e1d8ae to 14d6b04 Compare May 29, 2026 16:46

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 14d6b04 to 87fa933 Compare June 5, 2026 16:19

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 87fa933 to 20418f2 Compare June 10, 2026 18:55

openshift-ci Bot added ok-to-test and removed needs-ok-to-test labels Jun 10, 2026

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 20418f2 to 4410650 Compare June 15, 2026 17:17

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 4410650 to b712848 Compare June 18, 2026 17:41

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from b712848 to 5aab2a7 Compare June 26, 2026 18:05

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from 5aab2a7 to d4e0086 Compare June 29, 2026 15:40

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from d4e0086 to f06ca3b Compare July 6, 2026 16:15

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from f06ca3b to be14c9a Compare July 23, 2026 18:03

Remove deprecated GO111MODULE=auto from Makefile

1163da7

GO111MODULE=auto has been a no-op since Go 1.21+ where module mode is always enabled. The project uses Go 1.25.

sebrandon1 force-pushed the cleanup/remove-go111module-auto branch from be14c9a to 1163da7 Compare August 5, 2026 19:16

Uh oh!

Conversation

sebrandon1 commented Mar 26, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related PRs

Jira

Test Plan

Uh oh!

openshift-ci-robot commented Mar 26, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

openshift-ci Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

github-actions Bot commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

sebrandon1 commented May 4, 2026

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

sebrandon1 commented Jun 10, 2026

Uh oh!

yuumasato commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

openshift-ci Bot commented Aug 5, 2026

Uh oh!

openshift-ci-robot commented Aug 5, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related PRs

Jira

Test Plan

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

openshift-ci Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sebrandon1 commented Mar 26, 2026 •

edited by atlassian Bot

Loading

openshift-ci-robot commented Mar 26, 2026 •

edited by atlassian Bot

Loading

openshift-ci-robot commented Aug 5, 2026 •

edited by atlassian Bot

Loading

openshift-ci Bot commented Aug 5, 2026 •

edited

Loading