[CU-34qhnj1] add lend and unlend functions to Lending pallet

[kkast]

add lend and unlend functions to Lending pallet, fixing tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated
pablo-nightly	⬜️ Ignored (Inspect)		Dec 13, 2022 at 9:15PM (UTC)
picasso-nightly	⬜️ Ignored (Inspect)		Dec 13, 2022 at 9:15PM (UTC)

[github-actions]

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/7c30cf1a3edb62e0475511a684ad030f4dcf9c03 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/7c30cf1a3edb62e0475511a684ad030f4dcf9c03#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/7c30cf1a3edb62e0475511a684ad030f4dcf9c03#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/7c30cf1a3edb62e0475511a684ad030f4dcf9c03#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/7c30cf1a3edb62e0475511a684ad030f4dcf9c03#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

[benluelo]

lend and unlend are pretty vague - perhaps something like deposit and withdraw (which is the same as the underlying vault functions called in these extrinsics)

Also, what's the purpose of these extrinsics? The relevant clickup ticket is empty: https://app.clickup.com/t/34qhnj1

[benluelo]

Also please run nix run ".#fmt"

[kkast]

lend and unlend are pretty vague - perhaps something like deposit and withdraw (which is the same as the underlying vault functions called in these extrinsics)

Also, what's the purpose of these extrinsics? The relevant clickup ticket is empty: https://app.clickup.com/t/34qhnj1

the idea to use lend and unlend instead of deposit and withdraw i think is because there is already deposit_collateral and withdraw_collateral. rn, Lending pallet doesnt have extrinsic to work with vault. it needs to use vault extrinsics to deposit or withdraw. we want to have these functions here in order to pause them if necessary.

[benluelo]

lend and unlend are pretty vague - perhaps something like deposit and withdraw (which is the same as the underlying vault functions called in these extrinsics)
Also, what's the purpose of these extrinsics? The relevant clickup ticket is empty: https://app.clickup.com/t/34qhnj1

the idea to use lend and unlend instead of deposit and withdraw i think is because there is already deposit_collateral and withdraw_collateral. rn, Lending pallet doesnt have extrinsic to work with vault. it needs to use vault extrinsics to deposit or withdraw. we want to have these functions here in order to pause them if necessary.

makes sense, but I see no reason why they couldn't be called vault_deposit and vault_withdraw though. Perhaps @kevin-composable can comment here

we want to have these functions here in order to pause them if necessary.
Maybe adding pausing functionality would be good?

[dzmitry-lahoda]

imho it is good to have pallet methods for that. so i never seen such naming before. can we have diffeerent names which are more common?

[dzmitry-lahoda]

lend does not happen when you call method. deposit and withdraw happen. so please rename.

[keronels-crypto]

disregard

[kevin-composable]

This looks perfect; vault_deposit and vault_withdraw sound good to me

[vimukthi-git]

LGTM :) Though I'm unable to provide much in-depth review or insight without a design/spec or details in the task linked.

[itsbobbyzz]

Task linked: CU-34qhnj1 Add vault_deposit + vault_withdraw extrinsics