Skip to content

Add add and delete extrinsics to pallet-crowdloan#2659

Merged
mergify[bot] merged 8 commits intomainfrom
Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b)
Dec 14, 2022
Merged

Add add and delete extrinsics to pallet-crowdloan#2659
mergify[bot] merged 8 commits intomainfrom
Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b)

Conversation

@KaiserKarel
Copy link
Contributor

No description provided.

@KaiserKarel KaiserKarel requested review from a team December 12, 2022 16:56
@KaiserKarel KaiserKarel requested review from a team as code owners December 12, 2022 16:56
@vercel
Copy link

vercel bot commented Dec 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 13, 2022 at 9:37PM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 13, 2022 at 9:37PM (UTC)

@itsbobbyzz
Copy link

@github-actions
Copy link

github-actions bot commented Dec 12, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/eb9c9ec832d120fa071a063442d84322f122265f --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/eb9c9ec832d120fa071a063442d84322f122265f#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/eb9c9ec832d120fa071a063442d84322f122265f#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/eb9c9ec832d120fa071a063442d84322f122265f#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/eb9c9ec832d120fa071a063442d84322f122265f#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

Copy link
Contributor

@vimukthi-git vimukthi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly no need of adding delete or any of the extrinisics

@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch from 5ba63b0 to 64f915f Compare December 12, 2022 18:24
@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch from 64f915f to 320aa1a Compare December 12, 2022 18:25
@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch from e55d839 to f6e3863 Compare December 12, 2022 18:45
@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch 2 times, most recently from d68534e to 5d887aa Compare December 12, 2022 19:51
Copy link
Contributor

@vimukthi-git vimukthi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think the validation may be needed to avoid a case of users claims erroring out. But I think that is manageable. We may do some manual checks on the balance of the pallet account in Picasso chain to verify that would not happen.

@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch 5 times, most recently from 688e341 to 52ec6c7 Compare December 12, 2022 21:44
@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch from 52ec6c7 to df3327e Compare December 12, 2022 23:16
@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch from df3327e to 315e8aa Compare December 13, 2022 00:33
Copy link
Contributor

@andyjsbell andyjsbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @KaiserKarel

(trigger ci)
@KaiserKarel KaiserKarel force-pushed the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch from 3ca8372 to eb9c9ec Compare December 13, 2022 21:37
mergify bot added a commit that referenced this pull request Dec 13, 2022
@KaiserKarel
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Dec 14, 2022
@mergify mergify bot merged commit 7c54cbc into main Dec 14, 2022
@mergify mergify bot deleted the Add-add-and-delete-extrinsics-to-pallet-crowdloan-(CU-39qvt6b) branch December 14, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants