[pull] master from WordPress:master#17
Merged
pull[bot] merged 336 commits intoConnectionMaster:masterfrom Jul 26, 2021
Merged
Conversation
…_metadata()` per the documentation standards. Follow-up to [23766], [25968], [35554], [51162]. Props hellofromTonya. Fixes #52603. Built from https://develop.svn.wordpress.org/trunk@51166 git-svn-id: http://core.svn.wordpress.org/trunk@50775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…typography keys. This avoids an "Undefined index" PHP notice on blocks without a `supports` key in `block.json`. Follow-up to [51089], [51153], [51159]. Props walbo. Fixes #53416. Built from https://develop.svn.wordpress.org/trunk@51167 git-svn-id: http://core.svn.wordpress.org/trunk@50776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…n standards. Follow-up to [51003], [51149]. See #52628. Built from https://develop.svn.wordpress.org/trunk@51168 git-svn-id: http://core.svn.wordpress.org/trunk@50777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Release notes: https://github.com/PHPMailer/PHPMailer/releases/tag/v6.5.0 For a full list of changes in this update, see the PHPMailer GitHub: PHPMailer/PHPMailer@v6.4.1...v6.5.0 Props ayeshrajans, Synchro. Fixes #53430. Built from https://develop.svn.wordpress.org/trunk@51169 git-svn-id: http://core.svn.wordpress.org/trunk@50778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…ous/next attachment links. This resolves a "Deprecated: Required parameter follows optional parameter" notice on PHP 8. Follow-up to [48794], [51122]. See #45708, #52625. Built from https://develop.svn.wordpress.org/trunk@51172 git-svn-id: http://core.svn.wordpress.org/trunk@50781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
If a custom plugin or theme exists in the `build/wp-content` directory with a sourcemap, the build` script is currently returning a warning and failing. This improves the `verify:source-maps` task in Grunt to ignore directories and files that do not belong to WordPress Core. Props ryelle, afragen, johnbillion. Fixes #52689. Built from https://develop.svn.wordpress.org/trunk@51173 git-svn-id: http://core.svn.wordpress.org/trunk@50782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…dget types controller. Follow-up to [50995]. Props ramonopoly, noisysocks, spacedmonkey, justinahinon, audrasjb, SergeyBiryukov. Fixes #53407. Built from https://develop.svn.wordpress.org/trunk@51174 git-svn-id: http://core.svn.wordpress.org/trunk@50783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
See #53407. Built from https://develop.svn.wordpress.org/trunk@51175 git-svn-id: http://core.svn.wordpress.org/trunk@50784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…ng metadata files. This ensures that block stylesheets are rendered properly when `should_load_separate_core_block_assets` filter is turned on. Follow-up to [50824], [50836]. Props walbo. Fixes #53440. Built from https://develop.svn.wordpress.org/trunk@51176 git-svn-id: http://core.svn.wordpress.org/trunk@50785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Props chintan1896, mukesh27. Fixes #53426. Built from https://develop.svn.wordpress.org/trunk@51177 git-svn-id: http://core.svn.wordpress.org/trunk@50786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…min/comment.php`. See #52627. Built from https://develop.svn.wordpress.org/trunk@51178 git-svn-id: http://core.svn.wordpress.org/trunk@50787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…e in tests. This switches to using Git in the local Docker environment install script to check out a copy of the WordPress Importer plugin for use in unit tests. Previously, SVN was used and the commands were not correctly run within the Docker container. The container does not actually have SVN installed, and the script was only working when the machine running the command had SVN present. Props czapla, alexstine, jnylen0, francina, desrosj. Fixes #52909. Built from https://develop.svn.wordpress.org/trunk@51179 git-svn-id: http://core.svn.wordpress.org/trunk@50788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
….7 or lower. This avoids a fatal error due to `WP_Block_Template` class redeclaration when updating to WordPress 5.8 with an older version of Gutenberg activated. Follow-up to [35582] for the REST API plugin. Props hellofromTonya, oglekler, azaozz, desrosj, pbiron, jorbin, youknowriad, TimothyBlynJacobs, Clorith, markparnell. See #53432. Built from https://develop.svn.wordpress.org/trunk@51180 git-svn-id: http://core.svn.wordpress.org/trunk@50789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…dings. Follow-up to [703/tests], [704/tests], [46586]. See #52625. Built from https://develop.svn.wordpress.org/trunk@51181 git-svn-id: http://core.svn.wordpress.org/trunk@50790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…?php` tag. This allows for using headers in the format of `<?php // Template Name: Something ?>`, which previously could not be recognized correctly. Props dd32, m_uysl, thomas-vitale, boblinthorst. Fixes #33387. Built from https://develop.svn.wordpress.org/trunk@51182 git-svn-id: http://core.svn.wordpress.org/trunk@50791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
… descriptions. Follow-up to [51174], [51175]. Props ocean90, ramonopoly. Fixes #53407. Built from https://develop.svn.wordpress.org/trunk@51183 git-svn-id: http://core.svn.wordpress.org/trunk@50792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…on on accepted arguments in `get_sites()`. Synchronize the documentation between two places, use `WP_Site_Query::__construct()` as the canonical source. Follow-up to [37616]. Props birgire, felipeelia, audrasjb. Fixes #42156. Built from https://develop.svn.wordpress.org/trunk@51184 git-svn-id: http://core.svn.wordpress.org/trunk@50793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Document the `$auto_update_settings` parameter of the `after_core_auto_updates_settings` action. Follow-up to [49254]. See #52628. Built from https://develop.svn.wordpress.org/trunk@51185 git-svn-id: http://core.svn.wordpress.org/trunk@50794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Follow-up to [49212], [49616], [49628], [49630]. See #52625. Built from https://develop.svn.wordpress.org/trunk@51186 git-svn-id: http://core.svn.wordpress.org/trunk@50795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Restore inheriting the backbone fetch in the media library and adapt the AJAX response according to the action performed in the media query. In [51145], the response shape was restored to the original shape, and a custom fetch was added to handle assigning the totalAttachments information in the collection. The custom fetch triggered a new set of bugs relating to zero-sized collections and loading individual images. props adamsilverstein, ryelle, peterwilsoncc, Presskopp, desrosj. Fixes #53421, #53419. Built from https://develop.svn.wordpress.org/trunk@51187 git-svn-id: http://core.svn.wordpress.org/trunk@50796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…header. There was no public release of WordPress 1.1. Follow-up to [803], [43662]. See #52628. Built from https://develop.svn.wordpress.org/trunk@51188 git-svn-id: http://core.svn.wordpress.org/trunk@50797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Follow-up to [51177]. Props chintan1896, mukesh27. Fixes #53459. Built from https://develop.svn.wordpress.org/trunk@51189 git-svn-id: http://core.svn.wordpress.org/trunk@50798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This is consistent with `get_the_author_posts_link()`. Props chintan1896. Fixes #50698. Built from https://develop.svn.wordpress.org/trunk@51190 git-svn-id: http://core.svn.wordpress.org/trunk@50799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add handlers to increment the total attachments count for the media collection when an item is added or removed. props adamsilverstein. Fixes #53171. Built from https://develop.svn.wordpress.org/trunk@51191 git-svn-id: http://core.svn.wordpress.org/trunk@50800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This fixes an issue where Query Loop blocks were displayed with list bullets and extra `padding-left`. Props AlePerez92, scruffian, ryelle. Fixes #53438. Built from https://develop.svn.wordpress.org/trunk@51192 git-svn-id: http://core.svn.wordpress.org/trunk@50801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…utenberg is not active. When a theme that uses the Full Site Editing feature is activated and the Gutenberg plugin is not present, the site will currently show a text notice on the front end. The user is not made aware of this unless they visit the front end of their site. This adds a check that will prevent a theme from being activated when the `full-site-editing` tag is present in the theme’s `style.css` header and the Gutenberg plugin is not active to prevent this scenario. These checks can be removed once Full Site Editing is completely merged into Core. Props desrosj, marybaum, chanthaboune. See #53410. Built from https://develop.svn.wordpress.org/trunk@51193 git-svn-id: http://core.svn.wordpress.org/trunk@50802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
After [51083], the Theme Details button is now displaying a border unintentionally. This removes it. Props ryelle. Fixes #53473. Built from https://develop.svn.wordpress.org/trunk@51194 git-svn-id: http://core.svn.wordpress.org/trunk@50803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This allows smaller screens to wrap error messages and other uploader media item elements in a more readable way. Props joedolson sabernhardt, Presskopp. See #51754. Built from https://develop.svn.wordpress.org/trunk@51195 git-svn-id: http://core.svn.wordpress.org/trunk@50804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This bumps the version for all bundle themes in preparation for release with WordPress 5.8. The new versions are as follows: - Twenty Twenty-One: 1.4 - Twenty Twenty: 1.8 - Twenty Nineteen: 2.1 - Twenty Seventeen: 2.8 - Twenty Sixteen: 2.5 - Twenty Fifteen: 3.0 - Twenty Fourteen: 3.2 - Twenty Thirteen: 3.4 - Twenty Twelve: 3.4 - Twenty Eleven: 3.8 - Twenty Ten: 3.4 Props mukesh27, kapilpaul. Fixes #53277. Built from https://develop.svn.wordpress.org/trunk@51455 git-svn-id: http://core.svn.wordpress.org/trunk@51066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This includes three minor updates to generated CSS files: - A single `-webkit-` prefix is removed for `min-width`, which was required for Safari <= 10.1 (0.06% total global usage). WordPress only supports the last two versions. - 2 instances where the `-o-` prefix are added for `tab-size`. This appears to be for Opera Mobile, which has creeped back over the 1% global usage. Props peterwilsoncc, jorbin. Fixes #53686. Built from https://develop.svn.wordpress.org/trunk@51456 git-svn-id: http://core.svn.wordpress.org/trunk@51067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Follow up to [51134]. Fixes #53367. Built from https://develop.svn.wordpress.org/trunk@51459 git-svn-id: http://core.svn.wordpress.org/trunk@51070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This replaces instances of `assertFalse( stripos( ... ) )` with `assertStringNotContainsString()` or `assertStringNotContainsStringIgnoringCase()` to use native PHPUnit functionality. Going forward, these methods introduced in PHPUnit 7.5 should be used for similar assertions: * `assertStringContainsString()` * `assertStringContainsStringIgnoringCase()` * `assertStringNotContainsString()` * `assertStringNotContainsStringIgnoringCase()` As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the `WP_UnitTestCase` class for PHPUnit < 7.5. Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436], [51438], [51448], [51449], [51451], [51453], [51454]. See #53363. Built from https://develop.svn.wordpress.org/trunk@51461 git-svn-id: http://core.svn.wordpress.org/trunk@51072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
… when used with strings. Using the `assertContains()` and `assertNotContains()` methods with string haystacks was deprecated in PHPUnit 8 and removed in PHPUnit 9. While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+. These methods introduced in PHPUnit 7.5 should be used as an alternative: * `assertStringContainsString()` * `assertStringContainsStringIgnoringCase` * `assertStringNotContainsString()` * `assertStringNotContainsStringIgnoringCase` As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods were added to the `WP_UnitTestCase` class for PHPUnit < 7.5. Follow-up to [51331], [51451], [51461]. Props jrf, dd32, SergeyBiryukov. See #53363, #46149. Built from https://develop.svn.wordpress.org/trunk@51462 git-svn-id: http://core.svn.wordpress.org/trunk@51073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…ng terminology. Fixes #53503, #53691 Built from https://develop.svn.wordpress.org/trunk@51463 git-svn-id: http://core.svn.wordpress.org/trunk@51074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…tering. Follow up to [50521]. Props david.binda. Fixes #53715. Built from https://develop.svn.wordpress.org/trunk@51467 git-svn-id: http://core.svn.wordpress.org/trunk@51078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…tering. The correct version is `4.3.0`. Follow up to [50546]. Props david.binda. Fixes #53714. Built from https://develop.svn.wordpress.org/trunk@51468 git-svn-id: http://core.svn.wordpress.org/trunk@51079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…ering. The correct version is `1.13.1`. Follow up to [50650], [50778]. Props david.binda. Fixes #53713. Built from https://develop.svn.wordpress.org/trunk@51469 git-svn-id: http://core.svn.wordpress.org/trunk@51080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The latest releases contain various bugfixes, as well as (nearly complete) support for PHP 8.0. Relevant changelogs: * https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.6 * https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.7 * https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.6.0 For a full list of changes in this update, see the PHP_CodeSniffer GitHub: squizlabs/PHP_CodeSniffer@3.5.5...3.6.0 Props jrf. Fixes #53477. Built from https://develop.svn.wordpress.org/trunk@51470 git-svn-id: http://core.svn.wordpress.org/trunk@51081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In WordPress 5.8 we added the ability to only load styles for blocks when these blocks are rendered. However, these optimizations left out block-styles that get added using the register_block_style() function/API. Props aristath. Fixes #53616. Built from https://develop.svn.wordpress.org/trunk@51471 git-svn-id: http://core.svn.wordpress.org/trunk@51082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Related issue in Gutenberg: WordPress/gutenberg#33552 The loop in WP_Theme_JSON_Resolver to extract translatable paths was broken, as it contained an immediate and unconditional return. This caused the loop to immediately exit again after the first iteration, thus never actually looping. Follow-up to [50959]. Props schlessera. Built from https://develop.svn.wordpress.org/trunk@51472 git-svn-id: http://core.svn.wordpress.org/trunk@51083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core. Follow-up to [47493], [48834], [50556], [51418]. Props radixweb, ankitmaru, TobiasBg, sabernhardt, audrasjb. Fixes #53716. Built from https://develop.svn.wordpress.org/trunk@51473 git-svn-id: http://core.svn.wordpress.org/trunk@51084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…hp`. Follow-up to [50810], [50814]. Props GaryJ, rtm909. Fixes #53680. Built from https://develop.svn.wordpress.org/trunk@51474 git-svn-id: http://core.svn.wordpress.org/trunk@51085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…files. This should make it clear that the variable is used as part of the HTML `<title>` tag on admin screens. Props ravipatel, hellofromTonya, sabernhardt, audrasjb, SergeyBiryukov. Fixes #53729. Built from https://develop.svn.wordpress.org/trunk@51475 git-svn-id: http://core.svn.wordpress.org/trunk@51086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A concrete test class should be suffixed with `Test`, not `UnitTestCase(s)`. Follow-up to [25053]. Props jrf. See #53363. Built from https://develop.svn.wordpress.org/trunk@51476 git-svn-id: http://core.svn.wordpress.org/trunk@51087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
See #53399 Built from https://develop.svn.wordpress.org/trunk@51477 git-svn-id: http://core.svn.wordpress.org/trunk@51088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…stCase_Base`. All assertions in PHPUnit have a `$message` parameter. Setting this parameter allows to distinguish which assertion is failing when a test runs multiple assertions, making debugging of the tests easier. This optional parameter is now added for the assertion methods in the `WP_UnitTestCase_Base` class that were missing it. Props jrf. See #53363. Built from https://develop.svn.wordpress.org/trunk@51478 git-svn-id: http://core.svn.wordpress.org/trunk@51089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…dWhitespace()`. Follow-up to [51478]. Props johnbillion. See #53363. Built from https://develop.svn.wordpress.org/trunk@51479 git-svn-id: http://core.svn.wordpress.org/trunk@51090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
* Use `assertSame()` instead of `fail()` to display a proper message in case of failure. * Add an optional `$message` parameter for consistency with other assertions. Follow-up to [51478], [51479]. See #53363. Built from https://develop.svn.wordpress.org/trunk@51480 git-svn-id: http://core.svn.wordpress.org/trunk@51091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…lds()`: * Check if the object attribute exists before checking its value. * Mention the field name in error messages in case of failure. Follow-up to [51478], [51479], [51480]. Props jrf. See #53363. Built from https://develop.svn.wordpress.org/trunk@51481 git-svn-id: http://core.svn.wordpress.org/trunk@51092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
By using `get_template_directory()` instead of `get_stylesheet_directory()`, we make sure to include the `block-patterns.php` file from the parent theme. This avoids a PHP fatal error when using a child theme of Twenty Ten. Follow-up to [51106]. Props ryelle, sabernhardt, loranrendel. Fixes #53752. Built from https://develop.svn.wordpress.org/trunk@51482 git-svn-id: http://core.svn.wordpress.org/trunk@51093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
By using `get_template_directory_uri()` instead of `get_stylesheet_directory_uri()`, we make sure to include the images from the parent theme. This avoids displaying missing images in block patterns when using a child theme of Twenty Ten, Twenty Eleven, or Twenty Twelve. Follow-up to [51033], [51103], [51106]. Props audrasjb. Fixes #53769. Built from https://develop.svn.wordpress.org/trunk@51483 git-svn-id: http://core.svn.wordpress.org/trunk@51094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Folow-up to [7043], [7062]. Props rudlinkon, hellofromTonya. Fixes #53764. Built from https://develop.svn.wordpress.org/trunk@51484 git-svn-id: http://core.svn.wordpress.org/trunk@51095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…()` before using it as a divisor. This avoids a "Division by zero" PHP warning if a plugin changes the `posts_per_page` value to zero. Follow-up to [51145]. Props 2linctools, kapilpaul, audrasjb. Fixes #53773. Built from https://develop.svn.wordpress.org/trunk@51485 git-svn-id: http://core.svn.wordpress.org/trunk@51096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Version bump three bundled themes to avoid file not found and fatal errors introduced for child themes during the 5.8 release cycle. * Twenty Ten: Version 3.5 (fatal error & 404) * Twenty Eleven: Version 3.9 (404) * Twenty Twelve: Version 3.5 (404) These updates will be released mid 5.8.1 cycle due to the severity of the issues. Follow up to [51482,51483]. Props dd32, peterwilsoncc. Fixes #53777. Built from https://develop.svn.wordpress.org/trunk@51486 git-svn-id: http://core.svn.wordpress.org/trunk@51097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `Block_Supported_Styles_Test` class is not a `TestCase` to be extended, but an actual concrete test class. In order to run as expected, it should be placed under `phpunit/tests/blocks/` along with the other block tests. Additionally: * Add missing visibility keywords to test methods. * Update the expected results to the currently used format for the tests to pass. * Remove two outdated tests. The functionality being tested there is no longer available in this manner, so these tests are redundant. Follow-up to [49226], [49310]. Props jrf, aristath, youknowriad. See #53363. Built from https://develop.svn.wordpress.org/trunk@51490 git-svn-id: http://core.svn.wordpress.org/trunk@51101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
trafico-bot
bot
added
✨ Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )