Colors#7
Conversation
…added color documentation
| from mpl_toolkits.mplot3d import Axes3D | ||
| import seaborn as sns | ||
|
|
||
| ##META## |
There was a problem hiding this comment.
this meta info could be removed (it's redundant with info on the github repo). or if we want to keep this, andy's name should be added.
There was a problem hiding this comment.
doesn't matter to me, whatever you'd prefer here.
There was a problem hiding this comment.
i don't think we need the meta info...we'll have a credit trail and contact info via github. unless you guys feel strongly i'd say expunge it.
| iargs = args_list[i] | ||
| ikwargs = kwargs_list[i] | ||
| ax.plot(data[i][0:half,0], data[i][half:m+1,0], *iargs, **ikwargs) | ||
|
|
There was a problem hiding this comment.
What's this function used for? It looks like it plots the first half of the data against the second half...
There was a problem hiding this comment.
I'm not actually sure. @KirstensGitHub ?
There was a problem hiding this comment.
if it's not used anywhere, we should delete it. and if it is used, we should re-write it to be more intuitive.
There was a problem hiding this comment.
this is out of the scope of the colors pr, but i'll make an issue to fix this
| pip install -e . | ||
|
|
||
| (this assumes you have pip installed on your system: https://pip.pypa.io/en/stable/installing/) | ||
|
|
There was a problem hiding this comment.
some additional instructions needed here on function names (by themselves these descriptions don't make sense)
There was a problem hiding this comment.
added some (hopefully) clearer instructions and a bunch of example uses
jeremymanning
left a comment
jeremymanning
left a comment
There was a problem hiding this comment.
I suggested a few minor changes below, and that I think should be addressed before we complete the pull into main. But overall this looks great!
andrewheusser
left a comment
andrewheusser
left a comment
There was a problem hiding this comment.
how/where do I add seaborn as a dependency?
| from mpl_toolkits.mplot3d import Axes3D | ||
| import seaborn as sns | ||
|
|
||
| ##META## |
There was a problem hiding this comment.
doesn't matter to me, whatever you'd prefer here.
| iargs = args_list[i] | ||
| ikwargs = kwargs_list[i] | ||
| ax.plot(data[i][0:half,0], data[i][half:m+1,0], *iargs, **ikwargs) | ||
|
|
There was a problem hiding this comment.
I'm not actually sure. @KirstensGitHub ?
|
to add seaborn as a dependency, you can add it to setup.py-- you add the line install_requires=['numpy', 'scipy', 'seaborn'] under the "py_modules" line the brain-dynamics-model repo (python folder) has an example if you want to check it out...i'll also upload to slack |
… legacy/kaleido/deps docs Release-review issues #3-#7, #9: - #3 (blocker): add dev-1.0/dev-1.0-refactor to pull_request.branches so PRs into the 1.0 line (incl. fork PRs) actually run CI -- the green matrix was push-triggered only. - #4: prune tests/screenshots (129 ignored files that graft-tests leaked into a 3.5MB sdist) + a packaging test asserting every sdist file is git-tracked or in a documented build-metadata allowlist. - #5: drop the untested Python 3.14 classifier (CI covers 3.10-3.13; dependency resolution is not a compiled-stack compatibility test). - #6: correct the legacy-geo docs -- pickle-format geos (>=0.8) load via the shim; pre-0.8 deepdish/HDF5 geos need a one-time numpy<2 conversion (with a concrete command); README + CHANGELOG. - #7: document that kaleido 1.x needs a Chrome/Chromium browser for static image export, with a troubleshooting pointer. - #9: replace the inaccurate 'small base install' wording with an honest description (the base pulls the full scientific stack); deps unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Addresses Jeremy's second release review (2026-07-18). Blocker #1 (sotus re-host) is code-ready pending its Dropbox upload; everything else lands here. - #2 (blocker) headless docs build: RTD now provisions a pinned Chrome for kaleido (.readthedocs.yaml post_install: plotly_get_chrome), a new `docs-clean` CI job builds the docs from a pristine `git archive` with `sphinx -W -E -a` (asserting docs/auto_examples is untracked) so a missing browser or any gallery-execution failure fails before it reaches RTD, and conf.py's fallback comment no longer overstates its coverage (it only guards a missing plotly import, not a missing Chrome). - #3 datasaurus indexes: hyp.load returns raw data, so each frame's original contiguous global-row-range index is part of the public result -- restore it from an in-package constant (_DATASAURUS_INDEX_STARTS) instead of a fresh RangeIndex. Add an immutable compatibility baseline (tests/data/rehosted_compat_baseline.json) + equivalence test covering every re-hosted dataset (values/index/columns/dtype/ordering), proven equal frame-by-frame to the pre-1.0 original. - #4 trust docstrings: load_source/_parse_payload now state that remote unpickling is REFUSED (raises HypertoolsTrustError), not warned. - #5 changelog: drop "small ... base install"; match the corrected README. - #6 atomic + concurrency-safe downloads: stream into a private temp file, verify its SHA-256, then os.replace into the cache (atomic rename); add a best-effort per-dataset filelock. A reader never sees a partial/unverified file, and an interrupted download leaves no corrupt cache entry. Real thread/atomicity tests added. - #7 merge strategy: CONTRIBUTING.md documents squash-merge (no history rewrite) so the branch's large-binary history never enters dev-1.0. - #8 sdist smoke: the release-qualification job now installs + smoke-tests the sdist in its own fresh venv too, not only the wheel. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
3 participants
Added color api
-supports seaborn and matplotlib color palettes e.g.
palette="Reds"-supports seaborn styles e.g.
style="whitegrid"-Unlabeled argument can be format string specified as a str, list or tuple. If str, sets all lines to specified style. If list/tuple, must be same length as x, and sets each line to specified value.
-Also accepts any unlabeled argument supported by matplotlib
-Keyword arguments can be str, list or tuple. color kwarg can be specified as a list of mixed types e.g.
color=['r',(.2,.4,.6),'#101010']. If list or tuple, must be same length as X. Can also list linestyles e.g.linestyle=[':','--','-']and markers e.g.marker=['o','*','^']