fix(ci): defer stale base-lock pins when the index is reachable - #727
fix(ci): defer stale base-lock pins when the index is reachable#727seonghobae wants to merge 5 commits into
Conversation
|
Warning Review limit reached
Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
@opencode-agent Please review exact head |
|
@opencode-agent Please review exact head |
|
Temporarily closing to respect dependency order and reduce the saturated Actions queue. This focused branch is preserved, but its current-head repository suite still inherits the existing CodeQL-version contract failure from |
Pull request was closed
Problem
The central
coverage-evidencesandbox currently turns an unavailable trusted-base dependency pin into a repository-wide review deadlock, even when the package index is reachable and offers newer versions.Live evidence from
ContextualWisdomLab/newsdom-api#467at head4ba5e81d8dba98fc97ba2f6964751cc958b58c9e:pypdf==6.13.3;coverage-evidencefailed before PR-head tests ran, so OpenCode submittedREQUEST_CHANGESand the protected queue could not self-heal through the dependency-upgrade PR.Change
Could not find a version ... (from versions: <non-empty list>)as a deferable trusted-base preflight failure;(from versions: none), a blank version list, registry/transport failures, hash mismatches, empty diagnostics, and unknown resolver failures fatal.TDD evidence
174a76cb52cc5aab06524ce8265794e7f2f6815d.(False, False)for the reachable-index andnonecounterexamples, so the reachable-index test failed for the intended missing behavior while the fail-closed control passed.(True, False).True.(True, False, False)for concrete,none, and blank lists.install_materialized_lockstests that prove the concrete list produces a visible skip and both non-evidence shapes abort the trusted build.Safety boundary
This changes provisioning classification, not coverage verdicts. A missing base pin may be skipped only when pip proves the index was reachable by listing at least one offered version. PR-head tests still run in the networkless sandbox and fail if the dependency was genuinely required.
Scope
Changed files:
scripts/ci/install_base_python_locks.pytests/test_install_base_python_lock_missing_pin.pyThis clean PR supersedes only the relevant classifier portion of #674. The unrelated model-budget, CodeQL, requirements-lock, and materializer changes accumulated on #674 are intentionally excluded and remain independently reviewable.