fix(ci): restore central review and security baseline - #729
Conversation
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Comment |
|
@opencode-agent Please review exact head |
|
@opencode-agent Please review exact head |
|
@opencode-agent Please review exact head |
Pull request was converted to draft
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headc73ee47861fca21e6959ce80fdf57b434c715c9d. -
Head SHA:
c73ee47861fca21e6959ce80fdf57b434c715c9d -
Workflow run: 30886138069
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["CI script: install_base_python_locks.py"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script: install_base_python_locks.py"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test: test_install_base_python_lock_missing_pin.py"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test: test_install_base_python_lock_missing_pin.py"]
R4 --> V4["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["CI script: install_base_python_locks.py"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script: install_base_python_locks.py"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test: test_install_base_python_lock_missing_pin.py"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test: test_install_base_python_lock_missing_pin.py"]
R4 --> V4["targeted test run"]
|
|
Recreating this exact branch as a ready-for-review PR because the connected review-state transition could not safely complete after the deliberate draft refresh. The head, six-file scope, successful direct checks, and TDD evidence are unchanged; no code is discarded and no protection is bypassed. |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headc73ee47861fca21e6959ce80fdf57b434c715c9d. -
Head SHA:
c73ee47861fca21e6959ce80fdf57b434c715c9d -
Workflow run: 30886641640
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["CI script: install_base_python_locks.py"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script: install_base_python_locks.py"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test: test_install_base_python_lock_missing_pin.py"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test: test_install_base_python_lock_missing_pin.py"]
R4 --> V4["targeted test run"]
Problem
Three defects on central
mainform a control-plane deadlock for dependency-upgrade PRs such asContextualWisdomLab/newsdom-api#467:init/analyzeuse 4.37.0 whileupload-sarifuses 4.37.4.Python Securityhard gate fails because Strix locks contain known-vulnerableaiohttp==3.14.1andcryptography==49.0.0.coverage-evidenceaborts while provisioning a trusted protected-base pin that a reachable index no longer offers, before it can test the dependency-upgrade PR head that fixes that pin.Separate PRs cannot pass independently: the CodeQL-only branch fails Python Security, the dependency-only branch fails the CodeQL contract, and the stale-pin classifier branch inherits both failures. This is the smallest atomic central-baseline repair that can satisfy every existing gate without bypassing any of them.
Changes
Restore CodeQL workflow consistency
github/codeql-action/initandanalyzereference incodeql-pr.ymlandscheduled-security-scan.ymlto the existing immutable 4.37.4 SHA already used by related CodeQL steps;Clear Strix Python dependency advisories
Exact log evidence from closed
.github#728, run30882962649, job91910729968reported:aiohttp==3.14.1: CVE-2026-59881, CVE-2026-69243, CVE-2026-69244; fixed by 3.14.3.cryptography==49.0.0: CVE-2026-69247; fixed by 50.0.0.This PR updates the direct cryptography pin to 50.0.0 and regenerates the fully hash-locked Strix closure with aiohttp 3.14.3 and cryptography 50.0.0, while preserving the intended Strix, Vertex AI, protobuf, multipart, and pyasn1 requirements.
Allow dependency upgrades to self-heal coverage
Could not find a version ... (from versions: <non-empty concrete list>), proving the index was reachable and offered other versions;(from versions: none), a blank version list, transport/registry failures, hash mismatches, empty diagnostics, and unknown resolver failures fatal.TDD evidence for stale-pin classification
none; the concrete-list case failed for the intended missing behavior.install_materialized_lockstests now prove:none→ fatal trusted-build error;Verification contracts
test_codeql_action_steps_use_one_version_per_workflowmust pass on the exact merge tree;Python Securitymust report zero known vulnerabilities for direct and hash-locked Strix requirements;Scope
Exactly six files change:
.github/workflows/codeql-pr.yml.github/workflows/scheduled-security-scan.ymlrequirements-strix-ci.txtrequirements-strix-ci-hashes.txtscripts/ci/install_base_python_locks.pytests/test_install_base_python_lock_missing_pin.pyNo application code, scheduler policy, token permission, model budget, or security-gate weakening.
Supersession
This clean atomic repair supersedes the relevant portions of closed #674, #723, #727, and #728. Their unrelated accumulated changes remain excluded.