feat(corpus): refuse TF-IDF and BM25 as inferential weights - #63
Draft
seonghobae wants to merge 1 commit into
Draft
feat(corpus): refuse TF-IDF and BM25 as inferential weights#63seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Only group-normalized ESS and uniform observation weights may enter an estimator. TF-IDF, BM25, and default global stopword deletion fail closed.
5 tasks
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#37–#62 remain review-blocked (no independent APPROVE). #37 and #45 kept ready. Next no-0008 gap: inferential-weight refusal in existing
corpus_split(does not recreatetopic_measurement#48,concept_dictionary#53, or allocate 0008).refuse_inferential_retrieval_weightadmits onlygroup_normalized_essanduniformrefuse_default_stopword_deletionrefuses global stopword listsTest plan
inferential_weight_contractfailed withE0432/E0599cargo test -p corpus_split --offlinecargo clippy -p corpus_split --all-targets --offline -- -D warningspython3 scripts/validate_documentation.pyandcheck_docstrings.pyDo not self-approve or merge. Prefer merge #37 then #45 when eligible. Do not allocate 0008.