fix(csp): hash the exact emitted inline style bytes - #363
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Comment |
Problem
The generated page declared a
style-srcSHA-256 hash for an inline stylesheet, but template indentation and leading/trailing whitespace could make the emitted<style>text differ from the string that was hashed. Browsers then block the stylesheet under the otherwise restrictive CSP.Repair
trimIndent();<style>tags;default-src 'none',base-uri 'none', andform-action 'none'without addingunsafe-inlineor a broader source;docs/doctoringwith an APA 7th reference; andUnreleasedinCHANGELOG.md.Product-level regression
CspHashTest.emittedStyleBytesMatchTheDeclaredCspHashcreates a real temporary directory, invokesprocess_dir, extracts the actual emitted style text and CSP hash-source, independently recomputes SHA-256 over the exact UTF-8 bytes, and requires equality. It also rejects leading or trailing template padding.Verification
The regression-test commit passed repository CI, JaCoCo coverage verification, Security Scan, and Semgrep. The current exact head must pass fresh versions of those checks plus current-head automated and independent review before merge. Queued, skipped, cancelled, absent, stale-head, or failed results are not treated as success.
No formal W3C conformance claim is made; the cited CSP Level 3 publication is a current Working Draft.