Skip to content

fix(csp): hash the exact emitted inline style bytes - #363

Merged
seonghobae merged 4 commits into
masterfrom
fix/csp-hash-11388474178076982133
Aug 5, 2026
Merged

fix(csp): hash the exact emitted inline style bytes#363
seonghobae merged 4 commits into
masterfrom
fix/csp-hash-11388474178076982133

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Problem

The generated page declared a style-src SHA-256 hash for an inline stylesheet, but template indentation and leading/trailing whitespace could make the emitted <style> text differ from the string that was hashed. Browsers then block the stylesheet under the otherwise restrictive CSP.

Repair

  • normalize the immutable stylesheet once with trimIndent();
  • calculate its SHA-256 Base64 source expression once per process;
  • inject exactly that normalized string between the <style> tags;
  • retain default-src 'none', base-uri 'none', and form-action 'none' without adding unsafe-inline or a broader source;
  • remove the duplicated per-directory digest work;
  • document the current CSP Level 3 byte-matching contract and threat boundary in docs/doctoring with an APA 7th reference; and
  • record the change under Unreleased in CHANGELOG.md.

Product-level regression

CspHashTest.emittedStyleBytesMatchTheDeclaredCspHash creates a real temporary directory, invokes process_dir, extracts the actual emitted style text and CSP hash-source, independently recomputes SHA-256 over the exact UTF-8 bytes, and requires equality. It also rejects leading or trailing template padding.

Verification

The regression-test commit passed repository CI, JaCoCo coverage verification, Security Scan, and Semgrep. The current exact head must pass fresh versions of those checks plus current-head automated and independent review before merge. Queued, skipped, cancelled, absent, stale-head, or failed results are not treated as success.

No formal W3C conformance claim is made; the cited CSP Level 3 publication is a current Working Draft.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: de8e2897-d6ed-4534-a2bc-4183c776849f

📥 Commits

Reviewing files that changed from the base of the PR and between a3c445e and 832e39e.

📒 Files selected for processing (5)
  • .jules/sentinel.md
  • CHANGELOG.md
  • docs/doctoring/csp-inline-style-byte-identity.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/CspHashTest.kt

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title 🛡️ Sentinel: [security improvement] fix(csp): hash the exact emitted inline style bytes Aug 5, 2026
@seonghobae
seonghobae enabled auto-merge (squash) August 5, 2026 05:06
This was referenced Aug 5, 2026
@seonghobae
seonghobae merged commit 060abbb into master Aug 5, 2026
29 checks passed
This was referenced Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant