Skip to content

Update contract admin#124

Merged
alpe merged 2 commits into0.9from
update_contract_admin
Jun 5, 2020
Merged

Update contract admin#124
alpe merged 2 commits into0.9from
update_contract_admin

Conversation

@alpe
Copy link
Copy Markdown
Contributor

@alpe alpe commented Jun 3, 2020

Resolves #117

--

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alpe alpe force-pushed the update_contract_admin branch from 9fda427 to e83d8ff Compare June 3, 2020 19:39
@alpe alpe requested a review from ethanfrey June 3, 2020 19:40
@alpe alpe force-pushed the update_contract_admin branch from e83d8ff to 01fa4fe Compare June 3, 2020 19:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #124 into 0.9 will decrease coverage by 0.28%.
The diff coverage is 49.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##              0.9     #124      +/-   ##
==========================================
- Coverage   62.36%   62.08%   -0.29%     
==========================================
  Files          20       20              
  Lines        1714     1762      +48     
==========================================
+ Hits         1069     1094      +25     
- Misses        553      576      +23     
  Partials       92       92              
Impacted Files Coverage Δ
x/wasm/handler.go 57.94% <0.00%> (-10.95%) ⬇️
x/wasm/internal/keeper/genesis.go 0.00% <0.00%> (ø)
x/wasm/internal/types/msg.go 44.33% <57.89%> (+2.96%) ⬆️
x/wasm/internal/keeper/keeper.go 86.32% <100.00%> (+0.61%) ⬆️
x/wasm/internal/types/codec.go 100.00% <100.00%> (ø)
lcd_test/helpers.go 76.25% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d8560...adb2b3b. Read the comment docs.

@alpe alpe force-pushed the update_contract_admin branch from 01fa4fe to 62b002b Compare June 4, 2020 06:59
@alpe alpe force-pushed the update_contract_admin branch from 62b002b to f2c417e Compare June 4, 2020 07:01
@alpe alpe marked this pull request as ready for review June 4, 2020 07:03
Copy link
Copy Markdown
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Two mainly stylistic issues. Feel free to address them as you feel fit and then merge.

Comment thread x/wasm/handler.go Outdated
Comment thread x/wasm/internal/keeper/keeper.go Outdated
Comment thread x/wasm/internal/types/msg.go
Comment thread x/wasm/internal/keeper/keeper_test.go
@alpe alpe merged commit 9a16d58 into 0.9 Jun 5, 2020
@alpe alpe deleted the update_contract_admin branch June 5, 2020 12:02
alpe added a commit that referenced this pull request Jun 9, 2020
* Add update administrator

* Review comments
zemyblue referenced this pull request in Finschia/wasmd Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants