Implement CLI/REST server support for new messages

[alpe]

🚧 After #124

• Resolves Add REST server support for new messages #119
• Resolves Add CLI client support for new messages #120

CLI/REST Support:

• Set/clear admin on contract
• Migrate contract to new code id

Reviewer note

• No tests implemented, yet 🚨
• Rest routes are currently discussed 🗣️

--

• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[alpe]

I did some manual tests with a local instance:

wasmcli keys add fred
wasmcli tx send $(wasmcli keys show validator -a) $(wasmcli keys show fred -a) 5000000ucosm --chain-id=testing
# store first version
wasmcli tx wasm store contract.wasm --from validator --gas 600000  -y --chain-id=testing
wasmcli query wasm list-code

# create instance with admin: fred
wasmcli tx wasm instantiate 1 '{"verifier":"cosmos1rsj2m3qas3jy50s8psns95qka09lhwhx2wvdq8","beneficiary":"cosmos1rsj2m3qas3jy50s8psns95qka09lhwhx2wvdq8"}'  --from validator --amount=50000ucosm  --label "escrow 1" -y --chain-id=testing --admin=$(wasmcli keys show fred -a)

# migrate with user validator => fails
wasmcli tx wasm migrate cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5 2 "{}" --from validator --chain-id=testing


# migrate with user fred => ok
wasmcli tx wasm migrate cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5 2 "{}" --from fred --chain-id=testing


# show status
wasmcli query wasm contract cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5

{
  "code_id": 2,
  "creator": "cosmos1r5kgu6y7fqfh4dksw4c28hv7ns9ydnusf33vgs",
  "admin": "cosmos1rsj2m3qas3jy50s8psns95qka09lhwhx2wvdq8",
  "label": "escrow 1",
  "init_msg": {
    "verifier": "cosmos1rsj2m3qas3jy50s8psns95qka09lhwhx2wvdq8",
    "beneficiary": "cosmos1rsj2m3qas3jy50s8psns95qka09lhwhx2wvdq8"
  },
  "address": "cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5"
}

[codecov-commenter]

Codecov Report

Merging #131 into 0.9 will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              0.9     #131      +/-   ##
==========================================
- Coverage   62.13%   62.06%   -0.08%     
==========================================
  Files          20       20              
  Lines        1764     1766       +2     
==========================================
  Hits         1096     1096              
- Misses        576      578       +2     
  Partials       92       92              

Impacted Files	Coverage Δ
x/wasm/internal/keeper/querier.go	36.13% <0.00%> (-0.62%)	⬇️
x/wasm/internal/types/types.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a16d58...233b508. Read the comment docs.

[ethanfrey]

Looks good. And there are unfortunately no tests for CLI/REST (most anywhere).
I just ask you to test them out manually before merging (honor system).

The PR looks good for adding TX support. However, it doesn't close the linked issues. For that it must add query support - adding the administrator field to the contract info - this is essential info to know if I want to trust a contract, as important as the code behind it.

[ethanfrey]

i didn't know this one. I like it.

i kind of think setting it to nil should require a bit more intention than a missing argument. but cli ux is definitely not high on my list of concerns (or anyone's I think).

Maybe a flag for this? Fine to leave as is.

[alpe]

👍 A flag is a good idea. Will add it.

[alpe]

Added --no-admin

[ethanfrey]

If you add the field to query and manually test, feel free to merge without another review

[ethanfrey]

Sorry @alpe, I missed that the field was there. I expected it needed a code change and didn't come automatically.

Good to merge as is

[alpe]

Manual CLI tests for set new contract admin

wasmcli keys add greg
wasmcli tx send $(wasmcli keys show validator -a) $(wasmcli keys show greg -a) 5000000ucosm --chain-id=testing

# non admin -> fail
wasmcli tx wasm set-contract-admin cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5  $(wasmcli keys show greg -a) --from validator --chain-id=testing

# as admin -> success
wasmcli tx wasm set-contract-admin cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5  $(wasmcli keys show greg -a) --from fred --chain-id=testing
# confirm
wasmcli query wasm contract cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5

# fred not admin -> fail
wasmcli tx wasm set-contract-admin cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5  $(wasmcli keys show greg -a) --from fred --chain-id=testing

# clear admin
wasmcli tx wasm set-contract-admin cosmos18vd8fpwxzck93qlwghaj6arh4p7c5n89uzcee5  --no-admin --from greg --chain-id=testing -y -b=block