Skip to content

Add sorting functionality to people column #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
use-tusk wants to merge 285 commits into from
Closed

Add sorting functionality to people column #2628

use-tusk wants to merge 285 commits into from

Conversation

@use-tusk
Copy link
Contributor

@use-tusk use-tusk bot commented Sep 26, 2024

Implemented sorting functionality for the people column in the Merge Suggestions Page. This involved adding new reactive sorting variables, updating the fetch function to include sorting parameters, and modifying the template to enable sorting by clicking on column headers. The people column can now be sorted alongside the confidence column.

Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review and I'll address it.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs to see more details.

skwowet and others added 30 commits December 21, 2023 16:15
@skwowet
Fix organization OpenSearch translator (#1987)
db3827f
@gaspergrom @joanagmaia
Enrichment sneak peak (#1941)
c5795f5 
Co-authored-by: Joana Maia <joana@crowd.dev>
@joanagmaia
Add async feedback to organizations merge (#1970)
55c819c
@joanagmaia
Fix display of attributes in contacts (#1989)
4f3cd0a
@garrrikkotua
Remove .git from GitHub and Git channels (#1990)
b2e323d
@joanagmaia
Fix null attribute (#1993)
66bf4e8
@joanagmaia
Fix reach display (#1992)
d879efd
@loicsaintroch
Init new members enrichment worker (#1942)
a969333
@skwowet
Index member reach as object in OpenSearch (#1995)
94a6ed4
@skwowet
add script to remove organization from OpenSearch (#1999)
f14e36d
@gaspergrom @joanagmaia
Pricing changes (#1973)
cb3be7f 
Co-authored-by: Joana Maia <joana@crowd.dev>
@gaspergrom
Handle plan manual cancelation
f4131b5
@skwowet
fix organization manual website update and handle error (#1997)
26afa9b
@sausage-todd
Org merge temporal (#2005)
637c77c
@skwowet
Fix 404 error in profile for organizations from member enrichment (#2008
246bfe5 
)
@joanagmaia
Fix generic boolean filter (#2009)
993989e
@loicsaintroch
Ignore wrong email addresses from enrichment (#2001)
57d3360
@epipav @loicsaintroch
Improvement/merge suggestions worker (#1971)
70d41ee 
Co-authored-by: Loïc Saint-Roch <loic@nunchi.studio>
@epipav
typo fixed in workflow names
2cdba7f
@epipav
filtering out null email values when getting merge suggestions
66b97c2
@epipav
deduplication using window function instead for stable results in mer…
62bbd4b 
…ge suggestions
@gaspergrom
Fix tenant identity (#2012)
fcbb7d0
@epipav
Improvement/prevent creation of duplicate member suggestions (#2022)
d392c1b
@epipav
More optimization on member merge suggestions getter (#2024)
25e532b
@epipav
Add optional similarity filter in member merge suggestions for segmen…
a243e29 
…t enabled deployments (#2026)
@gaspergrom @epipav
Common actions and merge suggestions on member pages (#2018)
1f4545e 
Co-authored-by: anilb <epipav@gmail.com>
@gaspergrom
Change layout for merge suggestions (#2011)
f1fe904
@loicsaintroch
Do not override organization name on enrichment (#2027)
5440bb2
@joanagmaia
Refactor identities display (#2023)
6905f5c
@joanagmaia
Fix empty emails and phone numbers (#2028)
d28b124
gaspergrom and others added 19 commits March 19, 2024 09:35
@gaspergrom
Add service restart to cli (#2300)
3df577e
@joanagmaia
Fix export to CSV in reports (#2310)
786e7d2
@joanagmaia
Add default configs to lists (#2301)
1482d21
@epipav
Save sourceIds of GitHub identities in Github integration (#2313)
6c797d6
@garrrikkotua @gaspergrom
Feat/integration progress backend (#2315)
b653007 
Co-authored-by: Gašper Grom <gasper.grom@gmail.com>
@epipav
Syncing primary member to opensearch again after moving activities co…
665c2e1 
…mpletes (#2321)
fixed cubejs build
37145e5
@gaspergrom
Remove signup (#2329)
ece59cf
@sausage-todd
Disable process-old-results job on data-sink-worker (#2339)
a7f1eb0
@skwowet
Support more attributes in Organizations CSV export (#2338)
01e626c
@garrrikkotua
Feat/support GitHub deleted users (#2344)
1896136
@joanreyero
Development and deployment docs (#2355)
d91deb4
@skwowet
docs: how to create the dev app and permissions needed for integratio…
86506c1 
…ns (#2357)
ssl and no ssl hosting changes (#2363)
e48a5b2
@joanreyero
Update development-and-deployment.md (#2367)
947cc97
@epipav
update node version to 20 in all backend services
b5f17cb
@joanagmaia
Shutdown banner (#2394)
3b45221
wip oracle cloud
e03f518
@use-tusk
feat(member-merge): add sorting for people column in merge suggestions
7f92717
@niravpatel27
Copy link
Collaborator

niravpatel27 commented Sep 26, 2024

fix lint issues.

@joanreyero joanreyero changed the base branch from main to crowd-linux September 26, 2024 15:17
@joanreyero joanreyero changed the base branch from crowd-linux to main September 26, 2024 15:18
niravpatel27
niravpatel27 requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@niravpatel27 niravpatel27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint issue.

@use-tusk
Copy link
Contributor Author

use-tusk bot commented Sep 26, 2024

Addressing your review. View activity logs for details.

@use-tusk
Copy link
Contributor Author

use-tusk bot commented Sep 26, 2024

@niravpatel27 I've addressed your review. Add another review if minor changes are needed.

@use-tusk use-tusk bot requested a review from niravpatel27 September 26, 2024 15:26
@joanagmaia joanagmaia closed this May 9, 2025
@gaspergrom gaspergrom deleted the tusk-sortable-people-column-092620241457 branch September 25, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niravpatel27 niravpatel27 Awaiting requested review from niravpatel27

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.