Issues cleanup project - closing the old and tagging the rest

[PeridexisErrant]

(I'll keep updating this post as I continue looking into old issues; those which have been dealt with are no longer listed)

Issues which can be closed without further action:

• add-spatter plugin crashes the game on OSX add-spatter plugin crashes the game on OS X #205 - Only replicable with Masterwork raws
• Superdwarf arguments Superdwarf arguments #217 - Fixed in 40.13-r1
• Errors reading teleportbase.lua Errors reading teleportbase.lua #233 - not a standard DFHack script (masterwork with 34.14-r5; presumably a precursor of teleport.lua)
• Ruby 1.9 - require an ".so" file crashes (need to init stack?) Ruby 1.9 - require an ".so" file crashes (need to init stack?) #271 - Fixed
• std::hash template std::hash template #331 - problem with old GCC version, not code

Issues which may be closable, or require minor work:

• workflow CRAFTS does not recognize wax craft jobs workflow CRAFTS does not recognize wax craft jobs #154 - I'm pretty sure this has been resolved (but not certain).
• autolabor tells legends not to work autolabor tells legends not to work #174 - Again, I'm pretty sure this has been resolved (but not certain).
• Improvement for LUA API docs Improvement for LUA API docs #202 - A fix was turned down (Proposed fix for Issue #202: Improvement for LUA API docs #207); is this still an issue?
• Some Issues with Stonesense (Ramps + Crashing) Some Issues with Stonesense (Ramps + Crashing) #259 - actually a Stonesense issue, could be opened there
• 40.8-r2: Stonesense: stops working after unload plugin 40.8-r2: Stonesense: stops working after unload plugin #287 - Might be fixed by recent changes? (and could be moved to the ssense issue tracker)

Labels: there are currently seven defined; 2.0, bug, idea, LEGACY, Offsets, Part. resolved, and Wishlist. Due to the non-use of some labels, I suggest a different set: bug, idea, and internal. If this sounds good, I'll list labels by issue instead of some example issues for each label.

• bug is for bugs - code not working as intended.
  • examples: Missing static variable definition crashes DFHack compiled in debug mode #404, full-heal resurrection issues #395, removebadthoughts doesn't work in 40.14-r1 #375, Bug: infiniteSky resets sky level - also causing cave-ins #254, Missing strnlen on OSX #182, etc.
• idea is for ideas, suggestions, wishlist items, etc - not bugs, but things it would be nice to have.
  • examples: Issues cleanup project - closing the old and tagging the rest #406, tubefill will NOT prevent demons from spawning #372, Autolabor exclude using nickname #364, Autobutcher - don't keep animals that won't breed #357, LuaJIT? #274, etc.
• internal distinguishes issues related to the internal workings of DFHack (eg problems with offsets, alternative libraries, or compile errors) from user-facing issues such as scripts or available features.
  • examples: Persistent data should be stored differently #414, Missing static variable definition crashes DFHack compiled in debug mode #404, std::hash template #331, Trying to use the wrong libz? #276, LuaJIT? #274, etc.

[expwnent]

Thank you for compiling this list. I did manage to catch up with pull requests last release and I've been staying on top of them. I intend to catch up with the issues list next. This will be helpful.

[expwnent]

I closed the easy ones.

[PeridexisErrant]

Awesome! I was also impressed with the pull request cleanup :)

With all the obvious ones closed and a plan to do more, I think this one can close too.

[expwnent]

I'd rather leave it open for now to remind myself of your comments on the others.

[PeridexisErrant]

More in-depth investigation turned up a few less obvious cases that could be closed, and I'll keep poking around as the mood takes me. More use of issue tags would also be good - should I list suggestions for those too?

[expwnent]

It would be slightly more correct to comment directly on the issues than here. I have notifications set up so that I'll get an email for basically anything involving the project.

I misread. Tags suggestions are fine too.

[PeridexisErrant]

Updated with proposal for simplified issue label system. I'll do a list later if the system sounds good.

[expwnent]

I did a pass through all existing open issues. I'm not entirely certain how useful the internal tag is but I did it anyway for now. I separated the "bug report" tag from the "confirmed bug" tag. I have a feeling that may be useful for searching through closed bug reports. I'm not sure how useful the confirmed bug tag is because most of the time if we can confirm it we can fix it but it's there for now. Let me know if you have any more suggestions.