Unclickable title in search list fix

[Raf-atmire]

References

• Fixes An item missing dc.title is not selectable in the user interface in certain contexts DSpace#3104

Description

This PR ensures that Items in the search lists will always have a clickable title.
This is done by altering the retrieval of the first occurrence of dc.title to the call to dsoNameService.getName(this.dso); This method will then provide us with the name of the DSO by calling dso.firstMetadataValue('dc.title') || dso.name || this.translateService.instant('dso.name.untitled'); and therefore, if a dc.title and a dso name don't exist, it'll return an "Untitled" String which is translatable

Instructions for Reviewers

List of changes in this PR:

• Changed the retrieval of a dso's name in the search list from a dc.title metadata call to a more broad dsoNameService.getName call
• Changed the dsoNameService.getName call to return an "Untitled" translatable String if a DSO doesn't have a title/name
• Added tests for this behaviour

How to test this PR:

• Setup this Angular branch with the api7.dspace.org as backend
• Search for -dc.title:* in the search bar
• Verify that Items are returned with an "Untitled" name instead of them being unclickable

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[lgtm-com]

This pull request introduces 2 alerts when merging 91f11d6 into 1115c58 - view on LGTM.com

new alerts:

• 2 for Unused variable, import, function or class

[tdonohue]

👍 Thanks @Raf-atmire & @LotteHofstede ! I've tested & reviewed this. I've verified it works as described and fixes the problem.