Move correlation ID to store

[ybnd]

References

• Fixes CORRELATION_ID doesn't exist for first request of every client and for every request of non-JS clients #1281

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

List of changes in this PR

• A correlationId field was added to the store, where it can be initialized both server- and client-side
• A service was added to resolve the correlationId from a cookie or the store, or generate it on demand if there isn't one yet.
• Initialization logic was moved from AppModule to BrowserAppModule & ServerAppModule in order to initialize after the store is rehydrated. Because of this the client can pick up a correlation ID generated by the server if it doesn't have a cookie yet.

Testing

1. Start up a local Rest server and the UI using this PR branch in prod mode
2. Clear cookies or open an incognito window
3. In the Rest server logs, check that the correlation ID is present for all calls made by the node server
4. In the netwerk tab of the browser, verify that the same correlation ID is used in the request headers of the client side calls

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[ybnd]

Looks like there were some other test failures hiding behind the fdescribe. Not sure what's causing those rn, will take a closer look tomorrow

[tdonohue]

👍 Tested and this works. Thanks @ybnd ! I've verified that the first request has the Correlation ID set, and that the backend logs almost never have "unknown unknown" (except briefly during authentication, but that's expected based on backend's behavior)

That said, I have two very minor requests for this PR before we merge it. I'd appeciate it if you could add some more TypeDocs or basic comments to code files that do not have any comments. See inline below. Once those are added, I feel this could be merged.

[lgtm-com]

This pull request introduces 2 alerts when merging c1e8bbb into ba268d4 - view on LGTM.com

new alerts:

• 2 for Unused variable, import, function or class

[atarix83]

thanks @ybnd

LGTM. I've tested and verified that it works properly