Addition of missing params#1937
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Dec 2, 2022
Merged
Conversation
Adding missing params and their french translations for : licence approval, SHERPA, external sources and processes.
tdonohue
added
i18n / l10n
mhvezina
suggested changes
Oct 31, 2022
Contributor
mhvezina
left a comment
mhvezina
left a comment
There was a problem hiding this comment.
Thank you @pilasou for this translation. One comment though: I would use the infinitive and not the imperative tense to continue with the choices made with the existing translation (e.g. "Cliquer" instead of "Cliquez"). What do you think about this?
New commit to include changes after review of commit 3bf13c0
tdonohue
requested review from
mhvezina and
tdonohue
and removed request for
mhvezina
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing params and their french translations for : licence approval, SHERPA, external sources and processes.