Curate the English translation file (duplications, missing new lines)

[kanasznagyzoltan]

References

• No related issue (maintenance/cleanup PR)

Description

Curated the en.json5 translation file by removing duplicate keys, adding missing keys used in templates, and fixing formatting inconsistencies to ensure proper JSON5 structure.

Instructions for Reviewers

List of changes in this PR:

• Removed 6 duplicate translation keys that had identical entries in different locations
• Added 6 missing translation keys that were hardcoded in templates but missing from en.json5
• Fixed newline formatting for 113 entries that were missing blank line separators between consecutive keys
• Ensured consistent formatting across the entire file
• Verified all static translation keys in the codebase are now present in en.json5

Duplicates removed:

Key	Reason
collection.form.errors.entityType.required	Duplicate at line 1400 (kept line 1384)
collection.form.errors.submissionDefinition.required	Duplicate at line 1402 (kept line 1382)
form.other-information.person_identifier_orcid	Duplicate at line 2188 (kept "ORCID iD" version at line 2194)
item.preview.dc.identifier.other	Duplicate at line 3211 with wrong case (kept line 3183)
item.preview.dc.description	Duplicate at line 3271 missing colon (kept line 3179)
RELATION.Project.researchoutputs.search.results.head	Duplicate at line 4823 (kept line 4807)

Missing keys added:

Key	Value
context-menu.actions.subscription.frequency.required	"Please select a frequency"
external-login.confirmation.email	"Email"
external-login-page.orcid-confirmation.netid.label	"Account Identifier"
ldn-new-service.form.error.ldnurl.ldnUrlAlreadyAssociated	"This LDN URL is already associated with another service"
submission.sections.custom-url.label.remove	"Remove"
submission.sections.describe.relationship-lookup.toggle-dropdown	"Toggle dropdown"

Instructions for Reviewers

1. Verify the file is valid JSON5 syntax
2. Confirm no duplicate keys remain (3,892 unique keys)
3. Check that all entries have consistent blank line separators

Verification commands:

Check for duplicates

grep -E '^\s*"[^"]+":' src/assets/i18n/en.json5 | sort | uniq -d

Validate JSON5

npx json5 -v src/assets/i18n/en.json5

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @kanasznagyzoltan ! This cleanup looks correct to me. I also deployed it and verified there are no issues with the English version of the UI.

Looks like some of these i18n keys are specific to 10.0, so this wouldn't be possible to automatically backport. But, if you would like to manually backport any of these changes to 9.x (or earlier), please feel free to create a separate backport PR against dspace-9_x branch (and similar)

[kanasznagyzoltan]

Thank you @tdonohue!